Skip to content

Commit 9afe959

Browse files
committed
Fix: remove two redundant open operations
1 parent d927796 commit 9afe959

File tree

1 file changed

+20
-22
lines changed

1 file changed

+20
-22
lines changed

charon/pkgs/maven.py

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,17 +1032,16 @@ def _generate_rollback_archetype_catalog(
10321032
else:
10331033
# Re-render the result of our archetype un-merge to the
10341034
# local file, in preparation for upload.
1035-
with open(local, 'wb') as f:
1036-
content = MavenArchetypeCatalog(remote_archetypes)\
1037-
.generate_meta_file_content()
1038-
try:
1039-
overwrite_file(local, content)
1040-
except FileNotFoundError as e:
1041-
logger.error(
1042-
"Error: Can not create file %s because of some missing folders",
1043-
local,
1044-
)
1045-
raise e
1035+
content = MavenArchetypeCatalog(remote_archetypes)\
1036+
.generate_meta_file_content()
1037+
try:
1038+
overwrite_file(local, content)
1039+
except FileNotFoundError as e:
1040+
logger.error(
1041+
"Error: Can not create file %s because of some missing folders",
1042+
local,
1043+
)
1044+
raise e
10461045
__gen_all_digest_files(local)
10471046
return 1
10481047

@@ -1148,17 +1147,16 @@ def _generate_upload_archetype_catalog(
11481147
# Re-render the result of our archetype merge /
11491148
# un-merge to the local file, in preparation for
11501149
# upload.
1151-
with open(local, 'wb') as f:
1152-
content = MavenArchetypeCatalog(remote_archetypes)\
1153-
.generate_meta_file_content()
1154-
try:
1155-
overwrite_file(local, content)
1156-
except FileNotFoundError as e:
1157-
logger.error(
1158-
"Error: Can not create file %s because of some missing folders",
1159-
local,
1160-
)
1161-
raise e
1150+
content = MavenArchetypeCatalog(remote_archetypes)\
1151+
.generate_meta_file_content()
1152+
try:
1153+
overwrite_file(local, content)
1154+
except FileNotFoundError as e:
1155+
logger.error(
1156+
"Error: Can not create file %s because of some missing folders",
1157+
local,
1158+
)
1159+
raise e
11621160
__gen_all_digest_files(local)
11631161
return True
11641162

0 commit comments

Comments
 (0)