Skip to content

Commit 539b79d

Browse files
committed
RADAS: adjust some logging
1 parent f79eb0d commit 539b79d

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

charon/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ def validate(self) -> bool:
7676
return True
7777

7878
def umb_target(self) -> str:
79-
return f"amqps://{self.__umb_host.strip()}:{self.__umb_host_port}"
79+
if self.ssl_enabled():
80+
return f"amqps://{self.__umb_host.strip()}:{self.__umb_host_port}"
81+
else:
82+
return f"amqp://{self.__umb_host.strip()}:{self.__umb_host_port}"
8083

8184
def result_queue(self) -> str:
8285
return self.__result_queue.strip()

charon/pkgs/radas_sign.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -201,19 +201,25 @@ def __init__(self, payload: Any, rconf: RadasConfig):
201201

202202
def on_start(self, event):
203203
self._container = event.container
204-
self.log.debug("Start creating connection for sender")
204+
self.log.debug("Start creating connection for sender to %s", self.rconf.umb_target())
205205
conn = self._container.connect(
206206
url=self.rconf.umb_target(),
207-
ssl_domain=self._ssl
207+
ssl_domain=self._ssl,
208+
heartbeat=500
208209
)
209-
self.log.debug("Connection to %s is created.", conn.hostname)
210210
if conn:
211+
self.log.debug("Start creating sender")
211212
self._sender = self._container.create_sender(conn, self.rconf.request_channel())
213+
self.log.debug("Sender created. Remote address: %s", self._sender.target.address)
214+
215+
def on_connection_opened(self, event):
216+
conn = event.connection
217+
self.log.debug("Connection to %s is created.", conn.hostname)
212218

213219
def on_sendable(self, event):
214220
if not self._message_sent:
215221
msg = Message(body=self.payload, durable=True)
216-
self.log.debug("Sending message: %s to %s", msg.id, event.sender.target.address)
222+
self.log.debug("Sending message: %s to %s", msg.body, event.sender.target.address)
217223
self._send_msg(msg)
218224
self._message = msg
219225
self._message_sent = True
@@ -232,7 +238,7 @@ def on_released(self, event):
232238
self._handle_failed_delivery("Released")
233239

234240
def on_accepted(self, event):
235-
self.log.info("Message accepted by receiver: %s", event.delivery)
241+
self.log.info("Message accepted by receiver: %s", event.delivery.link.target.address)
236242
self.status = "success"
237243
self.close() # Close connection after confirmation
238244

@@ -251,26 +257,26 @@ def close(self):
251257
def _send_msg(self, msg: Message):
252258
if self._sender and self._sender.credit > 0:
253259
self._sender.send(msg)
254-
self.log.debug("Message %s sent", msg.id)
260+
self.log.debug("Message %s sent", msg.body)
255261
else:
256262
self.log.warning("Sender not ready or no credit available")
257263

258264
def _handle_failed_delivery(self, reason: str):
259265
if self._pending:
260266
msg = self._pending
261-
self.log.warning("Message %s failed for reason: %s", msg.id, reason)
267+
self.log.warning("Message %s failed for reason: %s", msg.body, reason)
262268
max_retries = self.rconf.radas_sign_timeout_retry_count()
263269
if self._retried < max_retries:
264270
# Schedule retry
265271
self._retried = self._retried + 1
266272
self.log.info("Scheduling retry %s/%s for message %s",
267-
self._retried, max_retries, msg.id)
273+
self._retried, max_retries, msg.body)
268274
# Schedule retry after delay
269275
if self._container:
270276
self._container.schedule(self.rconf.radas_sign_timeout_retry_interval(), self)
271277
else:
272278
# Max retries exceeded
273-
self.log.error("Message %s failed after %s retries", msg.id, max_retries)
279+
self.log.error("Message %s failed after %s retries", msg.body, max_retries)
274280
self.status = "failed"
275281
self._pending = None
276282
else:

0 commit comments

Comments
 (0)