From 1ffcb68cd36b0a673217f89d44f2c616527f49b6 Mon Sep 17 00:00:00 2001 From: Eric Chavaillaz Date: Sun, 30 Apr 2023 09:23:53 +0200 Subject: [PATCH] [BUGFIX] PDOStatement::fetch(): Passing null to parameter #1 () of type int is deprecated --- Classes/Backend/LocalizationController.php | 3 ++- Classes/Backend/TtContent.php | 3 ++- Classes/DataHandler/AbstractDataHandler.php | 8 ++++---- Classes/DataHandler/AfterDatabaseOperations.php | 12 ++++++------ Classes/DataHandler/PreProcessFieldArray.php | 2 +- Classes/DataHandler/ProcessCmdmap.php | 2 +- Classes/Helper/Helper.php | 2 +- Classes/Hooks/DrawItem.php | 2 +- Classes/PageLayoutView/ShortcutPreviewRenderer.php | 2 +- Classes/Plugin/Gridelements.php | 2 +- .../GridelementsBackendLayoutIconUpdateWizard.php | 2 +- ...entsBackendLayoutPiFlexformDsFileUpdateWizard.php | 2 +- Classes/Xclass/DatabaseRecordList10.php | 10 +++++----- 13 files changed, 27 insertions(+), 25 deletions(-) diff --git a/Classes/Backend/LocalizationController.php b/Classes/Backend/LocalizationController.php index 08ab4fc..4f236ab 100644 --- a/Classes/Backend/LocalizationController.php +++ b/Classes/Backend/LocalizationController.php @@ -17,6 +17,7 @@ * The TYPO3 project - inspiring people to share! */ +use PDO; use Psr\Http\Message\ResponseInterface; use Psr\Http\Message\ServerRequestInterface; use TYPO3\CMS\Backend\Domain\Repository\Localization\LocalizationRepository; @@ -90,7 +91,7 @@ public function getRecordLocalizeSummary(ServerRequestInterface $request): Respo $languageId ); - while ($row = $result->fetch()) { + while ($row = $result->fetch(PDO::FETCH_BOTH)) { BackendUtility::workspaceOL('tt_content', $row, -99, true); if (!$row || VersionState::cast($row['t3ver_state'])->equals(VersionState::DELETE_PLACEHOLDER)) { continue; diff --git a/Classes/Backend/TtContent.php b/Classes/Backend/TtContent.php index fa94baf..3e1bfa6 100644 --- a/Classes/Backend/TtContent.php +++ b/Classes/Backend/TtContent.php @@ -22,6 +22,7 @@ * This copyright notice MUST APPEAR in all copies of the script! ***************************************************************/ +use PDO; use TYPO3\CMS\Core\Database\Connection; use TYPO3\CMS\Core\Database\ConnectionPool; use TYPO3\CMS\Core\Database\Query\QueryBuilder; @@ -235,7 +236,7 @@ public function deleteDisallowedContainers(array &$params, string $itemUidList = ) ->execute(); $containers = []; - while ($container = $containerQuery->fetch()) { + while ($container = $containerQuery->fetch(PDO::FETCH_BOTH)) { $containers[$container['uid']] = $container; } foreach ($params['items'] as $key => $container) { diff --git a/Classes/DataHandler/AbstractDataHandler.php b/Classes/DataHandler/AbstractDataHandler.php index 702bab1..f8cac13 100644 --- a/Classes/DataHandler/AbstractDataHandler.php +++ b/Classes/DataHandler/AbstractDataHandler.php @@ -226,7 +226,7 @@ public function checkAndUpdateTranslatedElements(int $uid) ) ->setMaxResults(1) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (!empty($currentValues['l18n_parent'])) { $originalUid = (int)$currentValues['uid']; $queryBuilder = $this->getQueryBuilder(); @@ -248,7 +248,7 @@ public function checkAndUpdateTranslatedElements(int $uid) ) ->setMaxResults(1) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (is_array($currentValues)) { $updateArray = $currentValues; @@ -284,7 +284,7 @@ public function checkAndUpdateTranslatedElements(int $uid) ) ->execute(); $translatedElements = []; - while ($translatedElement = $translatedElementQuery->fetch()) { + while ($translatedElement = $translatedElementQuery->fetch(PDO::FETCH_BOTH)) { $translatedElements[$translatedElement['uid']] = $translatedElement; } if (empty($translatedElements)) { @@ -310,7 +310,7 @@ public function checkAndUpdateTranslatedElements(int $uid) ) ) ->execute(); - while ($translatedContainer = $translatedContainerQuery->fetch()) { + while ($translatedContainer = $translatedContainerQuery->fetch(PDO::FETCH_BOTH)) { $translatedContainers[$translatedContainer['sys_language_uid']] = $translatedContainer; } } diff --git a/Classes/DataHandler/AfterDatabaseOperations.php b/Classes/DataHandler/AfterDatabaseOperations.php index 1f05ce7..157f12c 100644 --- a/Classes/DataHandler/AfterDatabaseOperations.php +++ b/Classes/DataHandler/AfterDatabaseOperations.php @@ -162,7 +162,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $childElementsInUnavailableColumns = []; - while ($childElementInUnavailableColumns = $childElementsInUnavailableColumnsQuery->fetch()) { + while ($childElementInUnavailableColumns = $childElementsInUnavailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $childElementsInUnavailableColumns[] = $childElementInUnavailableColumns['uid']; } if (!empty($childElementsInUnavailableColumns)) { @@ -202,7 +202,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $childElementsInAvailableColumns = []; - while ($childElementInAvailableColumns = $childElementsInAvailableColumnsQuery->fetch()) { + while ($childElementInAvailableColumns = $childElementsInAvailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $childElementsInAvailableColumns[] = $childElementInAvailableColumns['uid']; } if (!empty($childElementsInAvailableColumns)) { @@ -287,7 +287,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $elementsInUnavailableColumns = []; - while ($elementInUnavailableColumns = $elementsInUnavailableColumnsQuery->fetch()) { + while ($elementInUnavailableColumns = $elementsInUnavailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $elementsInUnavailableColumns[] = $elementInUnavailableColumns['uid']; } if (!empty($elementsInUnavailableColumns)) { @@ -330,7 +330,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $elementsInAvailableColumns = []; - while ($elementInAvailableColumns = $elementsInAvailableColumnsQuery->fetch()) { + while ($elementInAvailableColumns = $elementsInAvailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $elementsInAvailableColumns[] = $elementInAvailableColumns['uid']; } if (!empty($elementsInAvailableColumns)) { @@ -383,7 +383,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $subPageElementsInUnavailableColumns = []; - while ($subPageElementInUnavailableColumns = $subPageElementsInUnavailableColumnsQuery->fetch()) { + while ($subPageElementInUnavailableColumns = $subPageElementsInUnavailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $subPageElementsInUnavailableColumns[] = $subPageElementInUnavailableColumns['uid']; } if (!empty($subPageElementsInUnavailableColumns)) { @@ -429,7 +429,7 @@ public function setUnusedElements(array &$fieldArray) ) ->execute(); $subPageElementsInAvailableColumns = []; - while ($subPageElementInAvailableColumns = $subPageElementsInAvailableColumnsQuery->fetch()) { + while ($subPageElementInAvailableColumns = $subPageElementsInAvailableColumnsQuery->fetch(PDO::FETCH_BOTH)) { $subPageElementsInAvailableColumns[] = $subPageElementInAvailableColumns['uid']; } if (!empty($subPageElementsInAvailableColumns)) { diff --git a/Classes/DataHandler/PreProcessFieldArray.php b/Classes/DataHandler/PreProcessFieldArray.php index 0a23a86..0047198 100644 --- a/Classes/DataHandler/PreProcessFieldArray.php +++ b/Classes/DataHandler/PreProcessFieldArray.php @@ -353,7 +353,7 @@ public function checkForRootColumn(int $contentId): int ) ) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (!empty($parent)) { if ($parent['tx_gridelements_container'] > 0) { $colPos = $this->checkForRootColumn($parent['tx_gridelements_container']); diff --git a/Classes/DataHandler/ProcessCmdmap.php b/Classes/DataHandler/ProcessCmdmap.php index 77ccd73..231e557 100644 --- a/Classes/DataHandler/ProcessCmdmap.php +++ b/Classes/DataHandler/ProcessCmdmap.php @@ -103,7 +103,7 @@ public function execute_processCmdmap( ) ) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (!empty($originalContainer)) { $containerUpdateArray[$originalContainer['tx_gridelements_container']] = -1; diff --git a/Classes/Helper/Helper.php b/Classes/Helper/Helper.php index f354638..fe790b2 100644 --- a/Classes/Helper/Helper.php +++ b/Classes/Helper/Helper.php @@ -184,7 +184,7 @@ public function getPidFromUid(int $uid = 0): int ) ) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); $pid = (int)$triggerElement['pid']; return is_array($triggerElement) && $pid ? $pid : 0; } diff --git a/Classes/Hooks/DrawItem.php b/Classes/Hooks/DrawItem.php index 57fc02f..c9e82ee 100644 --- a/Classes/Hooks/DrawItem.php +++ b/Classes/Hooks/DrawItem.php @@ -1457,7 +1457,7 @@ protected function collectContentData(string $shortcutItem, array &$collectedIte ) ->setMaxResults(1) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (!empty($this->extentensionConfiguration['overlayShortcutTranslation']) && $language > 0) { $translatedItem = BackendUtility::getRecordLocalization('tt_content', $item['uid'], $language); diff --git a/Classes/PageLayoutView/ShortcutPreviewRenderer.php b/Classes/PageLayoutView/ShortcutPreviewRenderer.php index 3cca6bf..1058a43 100644 --- a/Classes/PageLayoutView/ShortcutPreviewRenderer.php +++ b/Classes/PageLayoutView/ShortcutPreviewRenderer.php @@ -266,7 +266,7 @@ protected function collectContentData(string $shortcutItem, array &$collectedIte ) ->setMaxResults(1) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); if (!empty($this->extensionConfiguration['overlayShortcutTranslation']) && $language > 0) { $translatedItem = BackendUtility::getRecordLocalization('tt_content', $item['uid'], $language); diff --git a/Classes/Plugin/Gridelements.php b/Classes/Plugin/Gridelements.php index 940f3b9..33a1c4b 100644 --- a/Classes/Plugin/Gridelements.php +++ b/Classes/Plugin/Gridelements.php @@ -344,7 +344,7 @@ public function getChildren(int $element = 0, int $pid = 0, string $csvColumns = ->execute(); $this->cObj->data['tx_gridelements_view_children'] = []; - while ($child = $children->fetch()) { + while ($child = $children->fetch(PDO::FETCH_BOTH)) { // Versioning preview: $sorting = $child['sorting'] ?? ''; $this->getTSFE()->sys_page->versionOL('tt_content', $child, true); diff --git a/Classes/Updates/GridelementsBackendLayoutIconUpdateWizard.php b/Classes/Updates/GridelementsBackendLayoutIconUpdateWizard.php index baa3ba4..fae2f81 100644 --- a/Classes/Updates/GridelementsBackendLayoutIconUpdateWizard.php +++ b/Classes/Updates/GridelementsBackendLayoutIconUpdateWizard.php @@ -232,7 +232,7 @@ protected function migrateField(array $row) 'storage', $queryBuilder->createNamedParameter($storageUid, PDO::PARAM_INT) ) - )->execute()->fetch(); + )->execute()->fetch(PDO::FETCH_BOTH); // the file exists, the file does not have to be moved again if (is_array($existingFileRecord)) { diff --git a/Classes/Updates/GridelementsBackendLayoutPiFlexformDsFileUpdateWizard.php b/Classes/Updates/GridelementsBackendLayoutPiFlexformDsFileUpdateWizard.php index 2a1e146..601941c 100644 --- a/Classes/Updates/GridelementsBackendLayoutPiFlexformDsFileUpdateWizard.php +++ b/Classes/Updates/GridelementsBackendLayoutPiFlexformDsFileUpdateWizard.php @@ -232,7 +232,7 @@ protected function migrateField(array $row) 'storage', $queryBuilder->createNamedParameter($storageUid, PDO::PARAM_INT) ) - )->execute()->fetch(); + )->execute()->fetch(PDO::FETCH_BOTH); // the file exists, the file does not have to be moved again if (is_array($existingFileRecord)) { diff --git a/Classes/Xclass/DatabaseRecordList10.php b/Classes/Xclass/DatabaseRecordList10.php index 4ec1bd2..1f41894 100644 --- a/Classes/Xclass/DatabaseRecordList10.php +++ b/Classes/Xclass/DatabaseRecordList10.php @@ -457,14 +457,14 @@ public function getTable($table, $id, $rowList = ''): string $prevPrevUid = 0; // Get first two rows and initialize prevPrevUid and prevUid if on page > 1 if ($this->firstElementNumber > 2 && $this->iLimit > 0) { - $row = $queryResult->fetch(); + $row = $queryResult->fetch(PDO::FETCH_BOTH); $prevPrevUid = -((int)$row['uid']); - $row = $queryResult->fetch(); + $row = $queryResult->fetch(PDO::FETCH_BOTH); $prevUid = $row['uid']; } $accRows = []; // Accumulate rows here - while ($row = $queryResult->fetch()) { + while ($row = $queryResult->fetch(PDO::FETCH_BOTH)) { if (!$this->isRowListingConditionFulfilled($table, $row)) { continue; } @@ -567,7 +567,7 @@ public function getTable($table, $id, $rowList = ''): string ->from($table) ->andWhere(...$predicates) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); $lRow = is_array($tmpRow) ? $tmpRow : $lRow; } @@ -987,7 +987,7 @@ function ($attributeValue) { ->from($table) ->andWhere(...$predicates) ->execute() - ->fetch(); + ->fetch(PDO::FETCH_BOTH); $lRow = is_array($tmpRow) ? $tmpRow : $lRow; }