making the endingSong bool actually work

that variable has been there for 3 years btw😭

Author: NexIsDumb

source/funkin/backend/assets/ModsFolderLibrary.hx

@@ -26,10 +26,7 @@ class ModsFolderLibrary extends AssetLibrary implements IModsAssetLibrary {
 		this.folderPath = folderPath;
 		this.libName = libName;
 		this.prefix = 'assets/$libName/';
-		if(modName == null)
-			this.modName = libName;
-		else
-			this.modName = modName;
+		this.modName = modName == null ? libName : modName;
 		super();
 	}
 

source/funkin/game/PlayState.hx

@@ -1516,6 +1516,7 @@ class PlayState extends MusicBeatState
 	public function endSong():Void
 	{
 		scripts.call("onSongEnd");
+		endingSong = true;
 		canPause = false;
 		inst.volume = 0;
 		vocals.volume = 0;

source/funkin/menus/StoryMenuState.hx

@@ -272,8 +272,7 @@ class MenuCharacterSprite extends FlxSprite
 	public var oldChar:WeekData.WeekCharacter = null;
 
 	public function changeCharacter(data:WeekData.WeekCharacter) {
-		visible = (data != null && data.xml != null);
-		if (!visible) return;
+		if (!(visible = (data != null && data.xml != null))) return;
 
 		if (oldChar != (oldChar = data)) {
 			CoolUtil.loadAnimatedGraphic(this, data.spritePath);
@@ -342,7 +341,7 @@ class StoryWeeklist {
 	public function getWeeksFromSource(source:funkin.backend.assets.AssetsLibraryList.AssetSource, useTxt:Bool = true, loadCharactersData:Bool = true) {
 		var path:String = Paths.txt('weeks/weeks');
 		var weeksFound:Array<String> = useTxt && Paths.assetsTree.existsSpecific(path, "TEXT", source) ? CoolUtil.coolTextFile(path) :
-			[for(c in Paths.getFolderContent('data/weeks/weeks/', false, source)) if (Path.extension(c).toLowerCase() == "xml") Path.withoutExtension(c)];
+			[for (c in Paths.getFolderContent('data/weeks/weeks/', false, source)) if (Path.extension(c).toLowerCase() == "xml") Path.withoutExtension(c)];
 
 		if (weeksFound.length > 0) {
 			for (w in weeksFound) {