rename some agents

charleslien · charleslien · commit e1fc4194b2c5 · 2025-08-05T16:54:08.000-07:00
diff --git a/backend/src/__tests__/agent-id-resolution.test.ts b/backend/src/__tests__/agent-id-resolution.test.ts
@@ -1,3 +1,4 @@
+import { AgentTemplateTypes } from '@codebuff/common/types/session-state'
 import { resolveAgentId } from '@codebuff/common/util/agent-name-normalization'
 import { describe, expect, it, beforeEach } from 'bun:test'
 
@@ -22,8 +23,8 @@ describe('Agent ID Resolution', () => {
         parentPrompt: 'Test',
         inputSchema: {},
       },
-      file_picker: {
-        id: 'file_picker',
+      [AgentTemplateTypes.file_picker]: {
+        id: AgentTemplateTypes.file_picker,
         displayName: 'Fletcher',
         systemPrompt: 'Test',
         instructionsPrompt: 'Test',
@@ -86,7 +87,7 @@ describe('Agent ID Resolution', () => {
   describe('Direct ID Resolution', () => {
     it('should resolve built-in agent IDs directly', () => {
       expect(resolveAgentId('base', mockRegistry)).toBe('base')
-      expect(resolveAgentId('file_picker', mockRegistry)).toBe('file_picker')
+      expect(resolveAgentId('file-picker', mockRegistry)).toBe('file-picker')
     })
 
     it('should resolve custom agent IDs directly', () => {
@@ -115,7 +116,7 @@ describe('Agent ID Resolution', () => {
     it('should not add prefix to built-in agents', () => {
       // Built-in agents should be found directly, not with prefix
       expect(resolveAgentId('base', mockRegistry)).toBe('base')
-      expect(resolveAgentId('file_picker', mockRegistry)).toBe('file_picker')
+      expect(resolveAgentId('file-picker', mockRegistry)).toBe('file-picker')
     })
   })
 
diff --git a/backend/src/templates/agents/archive/dry-run.ts b/backend/src/templates/agents/archive/dry-run.ts
@@ -8,8 +8,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const dryRun = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['dry_run'].displayName,
-  parentPrompt: AGENT_PERSONAS['dry_run'].purpose,
+  displayName: AGENT_PERSONAS.dry_run.displayName,
+  parentPrompt: AGENT_PERSONAS.dry_run.purpose,
   inputSchema: {
     prompt: z.string().describe('A coding task to complete'),
   },
diff --git a/backend/src/templates/agents/ask.ts b/backend/src/templates/agents/ask.ts
@@ -14,7 +14,7 @@ import type { Model } from '@codebuff/common/constants'
 
 export const ask = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['ask'].displayName,
+  displayName: AGENT_PERSONAS.ask.displayName,
   parentPrompt: 'Base ask-mode agent that orchestrates the full response.',
   inputSchema: {
     prompt: z
diff --git a/backend/src/templates/agents/base.ts b/backend/src/templates/agents/base.ts
@@ -16,8 +16,8 @@ export const base = (
   allAvailableAgents?: string[],
 ): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['base'].displayName,
-  parentPrompt: AGENT_PERSONAS['base'].purpose,
+  displayName: AGENT_PERSONAS.base.displayName,
+  parentPrompt: AGENT_PERSONAS.base.purpose,
   inputSchema: {
     prompt: z.string().describe('A coding task to complete'),
   },
diff --git a/backend/src/templates/agents/file-picker.ts b/backend/src/templates/agents/file-picker.ts
@@ -8,8 +8,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const filePicker = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['file_picker'].displayName,
-  parentPrompt: AGENT_PERSONAS['file_picker'].purpose,
+  displayName: AGENT_PERSONAS.file_picker.displayName,
+  parentPrompt: AGENT_PERSONAS.file_picker.purpose,
   inputSchema: {
     prompt: z.string().describe('A coding task to complete'),
   },
diff --git a/backend/src/templates/agents/planner.ts b/backend/src/templates/agents/planner.ts
@@ -9,8 +9,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const planner = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['planner'].displayName,
-  parentPrompt: AGENT_PERSONAS['planner'].purpose,
+  displayName: AGENT_PERSONAS.planner.displayName,
+  parentPrompt: AGENT_PERSONAS.planner.purpose,
   inputSchema: {
     prompt: z
       .string()
diff --git a/backend/src/templates/agents/researcher.ts b/backend/src/templates/agents/researcher.ts
@@ -9,8 +9,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const researcher = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['researcher'].displayName,
-  parentPrompt: AGENT_PERSONAS['researcher'].purpose,
+  displayName: AGENT_PERSONAS.researcher.displayName,
+  parentPrompt: AGENT_PERSONAS.researcher.purpose,
   inputSchema: {
     prompt: z
       .string()
diff --git a/backend/src/templates/agents/reviewer.ts b/backend/src/templates/agents/reviewer.ts
@@ -9,8 +9,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const reviewer = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['reviewer'].displayName,
-  parentPrompt: AGENT_PERSONAS['reviewer'].purpose,
+  displayName: AGENT_PERSONAS.reviewer.displayName,
+  parentPrompt: AGENT_PERSONAS.reviewer.purpose,
   inputSchema: {
     prompt: z.string().describe('What should be reviewed. Be brief.'),
   },
diff --git a/backend/src/templates/agents/superagent.ts b/backend/src/templates/agents/superagent.ts
@@ -12,8 +12,8 @@ export const superagent = (
   allAvailableAgents?: string[],
 ): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['superagent'].displayName,
-  parentPrompt: AGENT_PERSONAS['superagent'].purpose,
+  displayName: AGENT_PERSONAS.superagent.displayName,
+  parentPrompt: AGENT_PERSONAS.superagent.purpose,
   inputSchema: {
     prompt: z.string().describe('A coding task to complete'),
   },
diff --git a/backend/src/templates/agents/thinker.ts b/backend/src/templates/agents/thinker.ts
@@ -9,8 +9,8 @@ import type { Model } from '@codebuff/common/constants'
 
 export const thinker = (model: Model): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['thinker'].displayName,
-  parentPrompt: AGENT_PERSONAS['thinker'].purpose,
+  displayName: AGENT_PERSONAS.thinker.displayName,
+  parentPrompt: AGENT_PERSONAS.thinker.purpose,
   inputSchema: {
     prompt: z.string().describe('The problem you are trying to solve'),
   },
diff --git a/backend/src/templates/agents/thinking-base.ts b/backend/src/templates/agents/thinking-base.ts
@@ -16,8 +16,8 @@ export const thinkingBase = (
   allAvailableAgents?: string[],
 ): Omit<AgentTemplate, 'id'> => ({
   model,
-  displayName: AGENT_PERSONAS['base_lite'].displayName,
-  parentPrompt: AGENT_PERSONAS['base_lite'].purpose,
+  displayName: AGENT_PERSONAS.base_lite.displayName,
+  parentPrompt: AGENT_PERSONAS.base_lite.purpose,
   inputSchema: {
     prompt: z.string().describe('A coding task to complete'),
   },
diff --git a/common/src/__tests__/dynamic-agent-template-schema.test.ts b/common/src/__tests__/dynamic-agent-template-schema.test.ts
@@ -132,7 +132,7 @@ describe('DynamicAgentConfigSchema', () => {
         ...validBaseTemplate,
         parentInstructions: {
           researcher: 'Spawn when you need research',
-          file_picker: 'Spawn when you need files',
+          [AgentTemplateTypes.file_picker]: 'Spawn when you need files',
           base: 'Spawn for general tasks',
         },
       }
@@ -363,7 +363,7 @@ describe('DynamicAgentConfigSchema', () => {
         invalid_agent: 'Invalid instruction',
         another_invalid: 'Another invalid instruction',
       }
-      const dynamicAgentIds = ['custom_agent']
+      const dynamicAgentIds = ['custom-agent']
 
       const result = validateParentInstructions(
         parentInstructions,
@@ -372,12 +372,12 @@ describe('DynamicAgentConfigSchema', () => {
       expect(result.valid).toBe(false)
       expect(result.invalidAgents).toEqual(['invalid_agent', 'another_invalid'])
       expect(result.availableAgents).toContain('researcher')
-      expect(result.availableAgents).toContain('custom_agent')
+      expect(result.availableAgents).toContain('custom-agent')
     })
 
     it('should format parent instructions error message correctly', () => {
       const invalidAgents = ['invalid_agent', 'another_invalid']
-      const availableAgents = ['researcher', 'file_picker', 'custom_agent']
+      const availableAgents = ['researcher', 'file-picker', 'custom-agent']
 
       const errorMessage = formatParentInstructionsError(
         invalidAgents,
@@ -387,7 +387,7 @@ describe('DynamicAgentConfigSchema', () => {
         'Invalid parent instruction agent IDs: invalid_agent, another_invalid',
       )
       expect(errorMessage).toContain(
-        'Available agents: researcher, file_picker, custom_agent',
+        'Available agents: researcher, file-picker, custom-agent',
       )
     })
   })
diff --git a/common/src/constants/agents.ts b/common/src/constants/agents.ts
@@ -1,3 +1,5 @@
+import type { AgentTemplateTypes } from 'src/types/session-state'
+
 // Define agent personas with their shared characteristics
 export const AGENT_PERSONAS = {
   // Base agents - all use Buffy persona
@@ -73,14 +75,16 @@ export const AGENT_PERSONAS = {
     purpose:
       'Reviews file changes and responds with critical feedback. Use this after making any significant change to the codebase.',
   } as const,
-  sonnet4_agent_builder: {
+  agent_builder: {
     displayName: 'Bob the Agent Builder',
     purpose: 'Creates new agent templates for the codebuff mult-agent system',
     hidden: false,
   } as const,
-} as const satisfies Record<
-  string,
-  { displayName: string; purpose: string; hidden?: boolean }
+} as const satisfies Partial<
+  Record<
+    keyof typeof AgentTemplateTypes,
+    { displayName: string; purpose: string; hidden?: boolean }
+  >
 >
 
 // Agent IDs list from AGENT_PERSONAS keys
