remove check new files necessary

Author: jahooma

backend/src/__tests__/request-files-prompt.test.ts

@@ -8,8 +8,6 @@ import {
   it,
 } from 'bun:test'
 
-// Import the entire module to spy on its exports
-import * as checkNewFilesNecessaryModule from '../find-files/check-new-files-necessary'
 import * as OriginalRequestFilesPromptModule from '../find-files/request-files-prompt'
 import * as geminiWithFallbacksModule from '../llm-apis/gemini-with-fallbacks'
 
@@ -18,17 +16,6 @@ import type { CodebuffMessage } from '@codebuff/common/types/message'
 import type { ProjectFileContext } from '@codebuff/common/util/file'
 import type { Mock } from 'bun:test'
 
-// Restore module-level mocks using bunMockFn for the mock implementations
-bunMockFn.module('../find-files/check-new-files-necessary', () => ({
-  checkNewFilesNecessary: bunMockFn(() =>
-    Promise.resolve({
-      newFilesNecessary: true,
-      response: 'YES',
-      duration: 100,
-    }),
-  ),
-}))
-
 bunMockFn.module('../llm-apis/gemini-with-fallbacks', () => ({
   promptFlashWithFallbacks: bunMockFn(() =>
     Promise.resolve('file1.ts\nfile2.ts'),
@@ -121,18 +108,6 @@ describe('requestRelevantFiles', () => {
       'getCustomFilePickerConfigForOrg',
     ).mockResolvedValue(null)
 
-    // Reset behavior and clear call history for module mocks
-    const checkNewFilesNecessaryMock =
-      checkNewFilesNecessaryModule.checkNewFilesNecessary as Mock<
-        typeof checkNewFilesNecessaryModule.checkNewFilesNecessary
-      >
-    checkNewFilesNecessaryMock.mockResolvedValue({
-      newFilesNecessary: true,
-      response: 'YES',
-      duration: 100,
-    })
-    checkNewFilesNecessaryMock.mockClear()
-
     const promptFlashWithFallbacksMock =
       geminiWithFallbacksModule.promptFlashWithFallbacks as Mock<
         typeof geminiWithFallbacksModule.promptFlashWithFallbacks
@@ -265,35 +240,4 @@ describe('requestRelevantFiles', () => {
     )
     expect(getCustomFilePickerConfigForOrgSpy).toHaveBeenCalled()
   })
-
-  it('should return null if checkNewFilesNecessary returns false', async () => {
-    // Override the module mock for this specific test case
-    ;(
-      checkNewFilesNecessaryModule.checkNewFilesNecessary as Mock<
-        typeof checkNewFilesNecessaryModule.checkNewFilesNecessary
-      >
-    ).mockResolvedValue({
-      newFilesNecessary: false,
-      response: 'NO',
-      duration: 50,
-    })
-
-    const result = await OriginalRequestFilesPromptModule.requestRelevantFiles(
-      { messages: mockMessages, system: mockSystem },
-      mockFileContext,
-      mockAssistantPrompt,
-      mockAgentStepId,
-      mockClientSessionId,
-      mockFingerprintId,
-      mockUserInputId,
-      mockUserId,
-      mockRepoId,
-    )
-
-    expect(result).toBeNull()
-    expect(
-      geminiWithFallbacksModule.promptFlashWithFallbacks,
-    ).not.toHaveBeenCalled()
-    expect(getCustomFilePickerConfigForOrgSpy).toHaveBeenCalled()
-  })
 })

backend/src/find-files/check-new-files-necessary.ts

@@ -12,7 +12,6 @@ import { getAllFilePaths } from '@codebuff/common/project-file-tree'
 import { and, eq } from 'drizzle-orm'
 import { range, shuffle, uniq } from 'lodash'
 
-import { checkNewFilesNecessary } from './check-new-files-necessary'
 import { CustomFilePickerConfigSchema } from './custom-file-picker-config'
 import { promptFlashWithFallbacks } from '../llm-apis/gemini-with-fallbacks'
 import { promptAiSdk } from '../llm-apis/vercel-ai-sdk/ai-sdk'
@@ -160,41 +159,6 @@ export async function requestRelevantFiles(
         : JSON.stringify(lastMessage.content)
       : ''
 
-  const newFilesNecessaryPromise = assistantPrompt
-    ? Promise.resolve({ newFilesNecessary: true, response: 'N/A', duration: 0 })
-    : checkNewFilesNecessary(
-        messagesExcludingLastIfByUser,
-        system,
-        clientSessionId,
-        fingerprintId,
-        userInputId,
-        userPrompt,
-        userId,
-      ).catch((error) => {
-        logger.error({ error }, 'Error checking new files necessary')
-        return { newFilesNecessary: true, response: 'N/A', duration: 0 }
-      })
-
-  // Await newFilesNecessaryPromise first
-  const newFilesNecessaryResult = await newFilesNecessaryPromise
-  const {
-    newFilesNecessary,
-    response: newFilesNecessaryResponse,
-    duration: newFilesNecessaryDuration,
-  } = newFilesNecessaryResult
-
-  if (!newFilesNecessary) {
-    logger.info(
-      {
-        newFilesNecessary,
-        response: newFilesNecessaryResponse,
-        duration: newFilesNecessaryDuration,
-      },
-      'requestRelevantFiles: No new files necessary, keeping current files',
-    )
-    return null // Early return if no new files are necessary
-  }
-
   // Only proceed to get key files if new files are necessary
   const keyPrompt = generateKeyRequestFilesPrompt(
     userPrompt,
@@ -242,9 +206,6 @@ export async function requestRelevantFiles(
   logger.info(
     {
       files,
-      newFilesNecessary,
-      newFilesNecessaryResponse,
-      newFilesNecessaryDuration,
       customFilePickerConfig: customFilePickerConfig,
       modelName: customFilePickerConfig?.modelName,
       orgId,