fix: address code review feedback for subscription-client branch

Author: brandonkachen

cli/src/components/chat-input-bar.tsx

@@ -6,7 +6,6 @@ import { FeedbackContainer } from './feedback-container'
 import { InputModeBanner } from './input-mode-banner'
 import { MultilineInput, type MultilineInputHandle } from './multiline-input'
 import { OutOfCreditsBanner } from './out-of-credits-banner'
-import { SubscriptionLimitBanner } from './subscription-limit-banner'
 import { PublishContainer } from './publish-container'
 import { SuggestionMenu, type SuggestionItem } from './suggestion-menu'
 import { useAskUserBridge } from '../hooks/use-ask-user-bridge'
@@ -191,11 +190,6 @@ export const ChatInputBar = ({
     return <OutOfCreditsBanner />
   }
 
-  // Subscription limit mode: replace entire input with subscription limit banner
-  if (inputMode === 'subscriptionLimit') {
-    return <SubscriptionLimitBanner />
-  }
-
   // Handle input changes with special mode entry detection
   const handleInputChange = (value: InputValue) => {
     // Detect entering bash mode: user typed exactly '!' when in default mode

cli/src/hooks/use-update-preference.ts

@@ -6,6 +6,7 @@ import {
   setActivityQueryData,
 } from './use-activity-query'
 import { subscriptionQueryKeys } from './use-subscription-query'
+import { showClipboardMessage } from '../utils/clipboard'
 import { getApiClient } from '../utils/codebuff-api'
 import { logger } from '../utils/logger'
 
@@ -55,6 +56,7 @@ export function useUpdatePreference() {
         setActivityQueryData(queryKey, previousData)
       }
       logger.error({ err }, 'Failed to update preference')
+      showClipboardMessage('Failed to update preference', { durationMs: 3000 })
     } finally {
       setIsPending(false)
     }

packages/billing/src/subscription-webhooks.ts

@@ -447,7 +447,7 @@ export async function handleSubscriptionScheduleCreatedOrUpdated(params: {
   const scheduledPriceId = nextPhase?.items?.[0]?.price
   const priceId = typeof scheduledPriceId === 'string'
     ? scheduledPriceId
-    : scheduledPriceId?.toString()
+    : scheduledPriceId?.id
 
   if (!priceId) {
     logger.warn(

web/src/app/api/user/subscription/route.ts

@@ -6,8 +6,6 @@ import {
 import { SUBSCRIPTION_DISPLAY_NAME } from '@codebuff/common/constants/subscription-plans'
 import db from '@codebuff/internal/db'
 import * as schema from '@codebuff/internal/db/schema'
-import { env } from '@codebuff/internal/env'
-import { stripeServer } from '@codebuff/internal/util/stripe'
 import { eq } from 'drizzle-orm'
 import { NextResponse } from 'next/server'
 import { getServerSession } from 'next-auth'
@@ -44,23 +42,9 @@ export async function GET() {
     return NextResponse.json(response)
   }
 
-  const stripeCustomerId = session.user.stripe_customer_id
-
-  const [rateLimit, limits, billingPortalUrl] = await Promise.all([
+  const [rateLimit, limits] = await Promise.all([
     checkRateLimit({ userId, subscription, logger }),
     getSubscriptionLimits({ userId, logger, tier: subscription.tier }),
-    stripeCustomerId
-      ? stripeServer.billingPortal.sessions
-          .create({
-            customer: stripeCustomerId,
-            return_url: `${env.NEXT_PUBLIC_CODEBUFF_APP_URL}/profile`,
-          })
-          .then((portalSession) => portalSession.url)
-          .catch((error) => {
-            logger.warn({ userId, error }, 'Failed to create billing portal session')
-            return undefined
-          })
-      : Promise.resolve(undefined),
   ])
 
   const response: ActiveSubscriptionResponse = {
@@ -87,7 +71,6 @@ export async function GET() {
       weeklyPercentUsed: rateLimit.weeklyPercentUsed,
     },
     limits,
-    billingPortalUrl,
     fallbackToALaCarte,
   }
   return NextResponse.json(response)