fix: add missing error handling and bounds checking

- Add .catch() handlers for unhandled promise rejections in CLI
- Add bounds checking before array access in chat.tsx
- Add error logging to silent catch blocks in SDK
- Add proper error reporting in agents/commander.ts
- Improve error messages in agents/thinker/thinker.ts

Author: brandonkachen

agents/commander.ts

@@ -63,6 +63,12 @@ Do not use any tools! Only analyze the output of the command.`,
   handleSteps: function* ({ params }: AgentStepContext) {
     const command = params?.command as string | undefined
     if (!command) {
+      // Using console.error because agents run in a sandboxed environment without access to structured logger
+      console.error('Commander agent: missing required "command" parameter')
+      yield {
+        toolName: 'set_output',
+        input: { output: 'Error: Missing required "command" parameter' },
+      }
       return
     }
 
@@ -81,7 +87,8 @@ Do not use any tools! Only analyze the output of the command.`,
     if (rawOutput) {
       // Return the raw command output without summarization
       const result = toolResult?.[0]
-      const output = result?.type === 'json' ? result.value : ''
+      // Only return object values (command output objects), not plain strings
+      const output = result?.type === 'json' && typeof result.value === 'object' ? result.value : ''
       yield {
         toolName: 'set_output',
         input: { output },

agents/thinker/thinker.ts

@@ -46,9 +46,12 @@ When satisfied, write out a brief response to the user's request. The parent age
       .find((m) => m.role === 'assistant')
 
     if (!lastAssistantMessage) {
+      const errorMsg = 'Error: No assistant message found in conversation history'
+      // Using console.error because agents run in a sandboxed environment without access to structured logger
+      console.error('Thinker agent:', errorMsg)
       yield {
         toolName: 'set_output',
-        input: { message: 'No response generated' },
+        input: { message: errorMsg },
       }
       return
     }

cli/src/chat.tsx

@@ -543,6 +543,7 @@ export const Chat = ({
             { error },
             '[followup-click] onSubmitPrompt failed with error',
           )
+          showClipboardMessage('Failed to send followup', { durationMs: 3000 })
         })
     }
 
@@ -997,12 +998,12 @@ export const Chat = ({
         let replacement: string
         const index = agentSelectedIndex
         if (index < agentMatches.length) {
-          const selected = agentMatches[index] || agentMatches[0]
+          const selected = agentMatches.length > 0 ? (agentMatches[index] || agentMatches[0]) : undefined
           if (!selected) return
           replacement = `@${selected.displayName} `
         } else {
           const fileIndex = index - agentMatches.length
-          const selectedFile = fileMatches[fileIndex] || fileMatches[0]
+          const selectedFile = fileMatches.length > 0 ? (fileMatches[fileIndex] || fileMatches[0]) : undefined
           if (!selectedFile) return
           replacement = `@${selectedFile.filePath} `
         }
@@ -1060,12 +1061,20 @@ export const Chat = ({
           }
 
           const cwd = getProjectRoot() ?? process.cwd()
-          void addPendingImageFromFile(result.imagePath, cwd, placeholderPath)
+          addPendingImageFromFile(result.imagePath, cwd, placeholderPath).catch(
+            (error) => {
+              logger.error({ error }, 'Failed to add pending image from file')
+              showClipboardMessage('Failed to add image', { durationMs: 3000 })
+            }
+          )
         }, 0)
       },
       onPasteImagePath: (imagePath: string) => {
         const cwd = getProjectRoot() ?? process.cwd()
-        void validateAndAddImage(imagePath, cwd)
+        validateAndAddImage(imagePath, cwd).catch((error) => {
+          logger.error({ error, imagePath }, 'Failed to validate and add image')
+          showClipboardMessage('Failed to add image', { durationMs: 3000 })
+        })
       },
       onPasteText: (text: string) => {
         setInputValue((prev) => {

cli/src/index.tsx

@@ -343,4 +343,7 @@ async function main(): Promise<void> {
   )
 }
 
-void main()
+main().catch((error) => {
+  logger.error(error, 'Unhandled error in main')
+  process.exit(1)
+})

cli/src/init/init-app.ts

@@ -26,8 +26,9 @@ export async function initializeApp(params: { cwd?: string }): Promise<void> {
   // This ensures the subscription status is up-to-date on startup
   const claudeCredentials = getClaudeOAuthCredentials()
   if (claudeCredentials) {
-    void getValidClaudeOAuthCredentials().catch(() => {
-      // Silently ignore refresh errors - will be retried on next API call
+    getValidClaudeOAuthCredentials().catch((error) => {
+      // Log refresh errors at debug level - will be retried on next API call
+      console.debug('Failed to refresh Claude OAuth credentials:', error)
     })
   }
 }

cli/src/utils/analytics.ts

@@ -88,16 +88,18 @@ function logAnalyticsDebug(message: string, data: Record<string, unknown>) {
   if (!DEBUG_ANALYTICS) {
     return
   }
-  void loadLogger()
+  loadLogger()
     .then(({ logger }) => {
       logger.debug(data, message)
     })
-    .catch(() => {
+    .catch((error) => {
       try {
         console.debug(message, data)
       } catch {
         // Ignore console errors in restricted environments
       }
+      // Log the error to help diagnose logger issues in debug mode
+      console.debug('Failed to load logger for analytics:', error)
     })
 }
 

sdk/src/agents/load-agents.ts

@@ -126,7 +126,7 @@ const getAllAgentFiles = (dir: string): string[] => {
       }
     }
   } catch {
-    // Ignore missing agent directories
+    // Expected for user agent directories that may not exist
   }
   return files
 }

sdk/src/run-state.ts

@@ -318,8 +318,8 @@ export async function loadUserKnowledgeFiles(params: {
   let entries: string[]
   try {
     entries = await fs.readdir(homeDir)
-  } catch {
-    logger.debug?.({ homeDir }, 'Failed to read home directory')
+  } catch (error) {
+    logger.debug?.({ homeDir, error: getErrorObject(error) }, 'Failed to read home directory')
     return userKnowledgeFiles
   }
 
@@ -347,8 +347,8 @@ export async function loadUserKnowledgeFiles(params: {
         userKnowledgeFiles[tildeKey] = content
         // Only use the first file found (highest priority)
         break
-      } catch {
-        logger.debug?.({ filePath }, 'Failed to read user knowledge file')
+      } catch (error) {
+        logger.debug?.({ filePath, error: getErrorObject(error) }, 'Failed to read user knowledge file')
       }
     }
   }