Skip to content

Commit 5458470

Browse files
committed
Run file change hooks *before* giving reviewer analysis. (We only return the last message!)
1 parent 5c447b9 commit 5458470

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.agents/factory/reviewer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@ export const reviewer = (model: Model): Omit<SecretAgentDefinition, 'id'> => ({
2121

2222
systemPrompt: `You are an expert programmer who can articulate very clear feedback on code changes.`,
2323

24-
instructionsPrompt: `Your task is to provide helpful feedback on the last file changes made by the assistant. You should critique the code changes made recently in the above conversation.
24+
instructionsPrompt: `Your task is to provide helpful feedback on the last file changes made by the assistant.
2525
26-
IMPORTANT: After analyzing the file changes, you should:
26+
IMPORTANT: Before analyzing the file changes, you should first:
2727
1. Run file change hooks to validate the changes using the run_file_change_hooks tool
2828
2. Include the hook results in your feedback - if any hooks fail, mention the specific failures and suggest how to fix them
2929
3. If hooks pass and no issues are found, mention that validation was successful
3030
4. Always run hooks for TypeScript/JavaScript changes, test file changes, or when the changes could affect compilation/tests
3131
3232
NOTE: You cannot make any changes directly! You can only suggest changes.
3333
34-
Provide specific feedback on the file changes made by the assistant, file-by-file.
34+
Next, you should critique the code changes made recently in the above conversation. Provide specific feedback on the file changes made by the assistant, file-by-file.
3535
3636
- Focus on getting to a complete and correct solution as the top priority.
3737
- Try to keep any changes to the codebase as minimal as possible.

0 commit comments

Comments
 (0)