Reorder agent-config a bit, update tools.d.ts, tweak changes-reviewer

Author: jahooma

.agents/changes-reviewer.ts

@@ -5,6 +5,18 @@ const config: AgentConfig = {
   version: '0.0.1',
   displayName: 'Changes Reviewer',
   model: 'x-ai/grok-4',
+  includeMessageHistory: false,
+
+  inputSchema: {
+    prompt: {
+      type: 'string',
+      description:
+        'Please provide a short description of the changes you want to review',
+    },
+  },
+  outputMode: 'last_message',
+
+  toolNames: ['read_files', 'run_terminal_command', 'end_turn'],
 
   parentPrompt: 'Spawn when you need to review code changes',
 
@@ -13,21 +25,16 @@ const config: AgentConfig = {
 
   instructionsPrompt: `
 Use the following guidelines to review the changes and suggest improvements:
-1. Find ways to simplify the code
-2. Reuse existing code as much as possible instead of writing new code
-3. Preserve as much behavior as possible in the existing code
-4. Prefer to change as few lines of code as possible
-5. Look for logical errors in the code
-6. Look for missed cases in the code
-7. Look for any other bugs
-8. Look for opportunities to improve the code's readability
+- Find ways to simplify the code
+- Reuse existing code as much as possible instead of writing new code
+- Preserve as much behavior as possible in the existing code
+- Prefer changing as few lines of code as possible
+- Look for opportunities to improve the code's readability
+- Look for logical errors in the code
+- Look for missed cases in the code
+- Look for any other bugs
     `.trim(),
 
-  includeMessageHistory: true,
-  outputMode: 'last_message',
-
-  toolNames: ['read_files', 'run_terminal_command', 'end_turn'],
-
   handleSteps: function* ({ agentState, prompt, params }: AgentStepContext) {
     // Step 1: Get list of changed files from git diff
     const { toolResult: gitDiffResult } = yield {
@@ -59,14 +66,13 @@ Use the following guidelines to review the changes and suggest improvements:
       },
     }
 
-    // Step 4: Extract file paths from git diff output
+    // Step 4: Extract file paths from git diff and status output
     const gitDiffOutput = gitDiffResult?.result || ''
     const changedFiles = gitDiffOutput
       .split('\n')
       .map((line) => line.trim())
       .filter((line) => line && !line.startsWith('??') && !line.includes('OSC'))
 
-    // Step 5: Extract untracked files from git status output
     const gitStatusOutput = gitStatusResult?.result || ''
     const untrackedFiles = gitStatusOutput
       .split('\n')
@@ -75,11 +81,11 @@ Use the following guidelines to review the changes and suggest improvements:
       .map((line) => line.substring(3).trim()) // Remove '?? ' prefix
       .filter((file) => file)
 
-    // Step 6: Combine all files to read
     const allFilesToRead = [...changedFiles, ...untrackedFiles].filter(
       (file) => file,
     )
 
+    // Step 5: Read the files
     if (allFilesToRead.length > 0) {
       yield {
         toolName: 'read_files',
@@ -89,9 +95,7 @@ Use the following guidelines to review the changes and suggest improvements:
       }
     }
 
-    // Step 7: Let AI review the changes
+    // Step 7: Let AI review the changes (and take as many steps as needed)
     yield 'STEP_ALL'
   },
 }
-
-export default config

.agents/types/tools.d.ts

@@ -1,3 +1,56 @@
+/**
+ * Union type of all available tool names
+ */
+export type ToolName =
+  | 'add_message'
+  | 'add_subgoal'
+  | 'browser_logs'
+  | 'code_search'
+  | 'create_plan'
+  | 'end_turn'
+  | 'find_files'
+  | 'read_docs'
+  | 'read_files'
+  | 'run_file_change_hooks'
+  | 'run_terminal_command'
+  | 'send_agent_message'
+  | 'set_messages'
+  | 'set_output'
+  | 'spawn_agents'
+  | 'spawn_agents_async'
+  | 'str_replace'
+  | 'think_deeply'
+  | 'update_subgoal'
+  | 'web_search'
+  | 'write_file'
+
+/**
+ * Map of tool names to their parameter types
+ */
+export interface ToolParamsMap {
+  add_message: AddMessageParams
+  add_subgoal: AddSubgoalParams
+  browser_logs: BrowserLogsParams
+  code_search: CodeSearchParams
+  create_plan: CreatePlanParams
+  end_turn: EndTurnParams
+  find_files: FindFilesParams
+  read_docs: ReadDocsParams
+  read_files: ReadFilesParams
+  run_file_change_hooks: RunFileChangeHooksParams
+  run_terminal_command: RunTerminalCommandParams
+  send_agent_message: SendAgentMessageParams
+  set_messages: SetMessagesParams
+  set_output: SetOutputParams
+  spawn_agents: SpawnAgentsParams
+  spawn_agents_async: SpawnAgentsAsyncParams
+  str_replace: StrReplaceParams
+  think_deeply: ThinkDeeplyParams
+  update_subgoal: UpdateSubgoalParams
+  web_search: WebSearchParams
+  write_file: WriteFileParams
+}
+
 /**
  * Add a new message to the conversation history. To be used for complex requests that can't be solved in a single step, as you may forget what happened!
  */
@@ -225,59 +278,6 @@ export interface WriteFileParams {
   content: string
 }
 
-/**
- * Union type of all available tool names
- */
-export type ToolName =
-  | 'add_message'
-  | 'add_subgoal'
-  | 'browser_logs'
-  | 'code_search'
-  | 'create_plan'
-  | 'end_turn'
-  | 'find_files'
-  | 'read_docs'
-  | 'read_files'
-  | 'run_file_change_hooks'
-  | 'run_terminal_command'
-  | 'send_agent_message'
-  | 'set_messages'
-  | 'set_output'
-  | 'spawn_agents'
-  | 'spawn_agents_async'
-  | 'str_replace'
-  | 'think_deeply'
-  | 'update_subgoal'
-  | 'web_search'
-  | 'write_file'
-
-/**
- * Map of tool names to their parameter types
- */
-export interface ToolParamsMap {
-  add_message: AddMessageParams
-  add_subgoal: AddSubgoalParams
-  browser_logs: BrowserLogsParams
-  code_search: CodeSearchParams
-  create_plan: CreatePlanParams
-  end_turn: EndTurnParams
-  find_files: FindFilesParams
-  read_docs: ReadDocsParams
-  read_files: ReadFilesParams
-  run_file_change_hooks: RunFileChangeHooksParams
-  run_terminal_command: RunTerminalCommandParams
-  send_agent_message: SendAgentMessageParams
-  set_messages: SetMessagesParams
-  set_output: SetOutputParams
-  spawn_agents: SpawnAgentsParams
-  spawn_agents_async: SpawnAgentsAsyncParams
-  str_replace: StrReplaceParams
-  think_deeply: ThinkDeeplyParams
-  update_subgoal: UpdateSubgoalParams
-  web_search: WebSearchParams
-  write_file: WriteFileParams
-}
-
 /**
  * Get parameters type for a specific tool
  */

common/src/util/agent-config.d.ts

@@ -4,18 +4,16 @@
  * This file provides TypeScript type definitions for creating custom Codebuff agents.
  * Import these types in your agent files to get full type safety and IntelliSense.
  *
- * Usage:
- *   import { AgentConfig, ToolName, ModelName } from './agent-config'
+ * Usage in .agents/your-agent.ts:
+ *   import { AgentConfig, ToolName, ModelName } from './types/agent-config'
  *
  *   const config: AgentConfig = {
- *     // Your agent configuration with full type safety
+ *     // ... your agent configuration with full type safety ...
  *   }
+ *   
+ *   export default config
  */
 
-import type * as Tools from './tools'
-export type { Tools }
-type ToolName = Tools.ToolName
-
 // ============================================================================
 // Core Agent Configuration Types
 // ============================================================================
@@ -43,26 +41,6 @@ export interface AgentConfig {
   /** Other agents this agent can spawn. */
   subagents?: SubagentName[]
 
-  // ============================================================================
-  // Prompts
-  // ============================================================================
-
-  /** Prompt for when to spawn this agent as a subagent. Include the main purpose and use cases.
-   * This field is key if the agent is a subagent and intended to be spawned. */
-  parentPrompt?: string
-
-  /** Background information for the agent. Fairly optional. Prefer using instructionsPrompt for agent instructions. */
-  systemPrompt?: string
-
-  /** Instructions for the agent.
-   * IMPORTANT: Updating this prompt is the best way to shape the agent's behavior.
-   * This prompt is inserted after each user input. */
-  instructionsPrompt?: string
-
-  /** Prompt inserted at each agent step. Powerful for changing the agent's behavior,
-   * but usually not necessary for smart models. Prefer instructionsPrompt for most instructions. */
-  stepPrompt?: string
-
   // ============================================================================
   // Input and Output
   // ============================================================================
@@ -78,21 +56,50 @@ export interface AgentConfig {
     params?: JsonSchema
   }
 
-  /** Whether to include conversation history. Defaults to false.
+  /** Whether to include conversation history from the parent agent in context.
+   * 
+   * Defaults to false.
    * Use this if the agent needs to know all the previous messages in the conversation.
    */
   includeMessageHistory?: boolean
 
   /** How the agent should output a response to its parent (defaults to 'last_message')
+   * 
    * last_message: The last message from the agent, typcically after using tools.
+   * 
    * all_messages: All messages from the agent, including tool calls and results.
+   * 
    * json: Make the agent output a JSON object. Can be used with outputSchema or without if you want freeform json output.
    */
   outputMode?: 'last_message' | 'all_messages' | 'json'
 
   /** JSON schema for structured output (when outputMode is 'json') */
   outputSchema?: JsonSchema
 
+  // ============================================================================
+  // Prompts
+  // ============================================================================
+
+  /** Prompt for when to spawn this agent as a subagent. Include the main purpose and use cases.
+   * 
+   * This field is key if the agent is a subagent and intended to be spawned. */
+  parentPrompt?: string
+
+  /** Background information for the agent. Fairly optional. Prefer using instructionsPrompt for agent instructions. */
+  systemPrompt?: string
+
+  /** Instructions for the agent.
+   * 
+   * IMPORTANT: Updating this prompt is the best way to shape the agent's behavior.
+   * This prompt is inserted after each user input. */
+  instructionsPrompt?: string
+
+  /** Prompt inserted at each agent step.
+   * 
+   * Powerful for changing the agent's behavior, but usually not necessary for smart models.
+   * Prefer instructionsPrompt for most instructions. */
+  stepPrompt?: string
+
   // ============================================================================
   // Handle Steps
   // ============================================================================
@@ -190,7 +197,6 @@ export interface ToolResult {
   result: string
 }
 
-
 /**
  * JSON Schema definition (for prompt schema or output schema)
  */
@@ -299,3 +305,7 @@ export type SubagentName =
   | 'thinker'
   | 'reviewer'
   | (string & {})
+
+import type * as Tools from './tools'
+export type { Tools }
+type ToolName = Tools.ToolName