fix opening login url on Windows

charleslien · charleslien · commit 18a12264f512 · 2025-06-09T11:45:48.000-07:00
diff --git a/npm-app/src/client.ts b/npm-app/src/client.ts
@@ -534,7 +534,7 @@ export class Client {
       let shouldRequestLogin = true
       CLI.getInstance().rl.once('line', () => {
         if (shouldRequestLogin) {
-          spawn(`open ${loginUrl}`, { shell: true })
+          spawn(process.platform === 'win32' ? 'start' : 'open', [loginUrl])
           console.log(
             "Opened a browser window to log you in! If it doesn't open automatically, you can click this link:"
           )

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,7 @@ export class Client {`
`534`	`534`	`let shouldRequestLogin = true`
`535`	`535`	`CLI.getInstance().rl.once('line', () => {`
`536`	`536`	`if (shouldRequestLogin) {`
`537`		- spawn(`open ${loginUrl}`, { shell: true })
	`537`	`+ spawn(process.platform === 'win32' ? 'start' : 'open', [loginUrl])`
`538`	`538`	`console.log(`
`539`	`539`	`"Opened a browser window to log you in! If it doesn't open automatically, you can click this link:"`
`540`	`540`	`)`