fix unit tests

Author: charleslien

backend/src/__tests__/main-prompt.test.ts

@@ -9,7 +9,10 @@ import {
   getToolCallString,
   renderToolResults,
 } from '@codebuff/common/tools/utils'
-import { getInitialSessionState } from '@codebuff/common/types/session-state'
+import {
+  AgentTemplateTypes,
+  getInitialSessionState,
+} from '@codebuff/common/types/session-state'
 import {
   afterAll,
   afterEach,
@@ -47,8 +50,8 @@ describe('mainPrompt', () => {
   beforeEach(() => {
     // Setup common mock agent templates
     mockLocalAgentTemplates = {
-      base: {
-        id: 'base',
+      [AgentTemplateTypes.base]: {
+        id: AgentTemplateTypes.base,
         displayName: 'Base Agent',
         outputMode: 'last_message',
         inputSchema: {},
@@ -61,8 +64,8 @@ describe('mainPrompt', () => {
         instructionsPrompt: '',
         stepPrompt: '',
       },
-      base_max: {
-        id: 'base_max',
+      [AgentTemplateTypes.base_max]: {
+        id: AgentTemplateTypes.base_max,
         displayName: 'Base Max Agent',
         outputMode: 'last_message',
         inputSchema: {},
@@ -256,7 +259,7 @@ describe('mainPrompt', () => {
         clientSessionId: 'test-session',
         onResponseChunk: () => {},
         localAgentTemplates: {
-          base: {
+          [AgentTemplateTypes.base]: {
             id: 'base',
             displayName: 'Base Agent',
             outputMode: 'last_message',
@@ -270,7 +273,7 @@ describe('mainPrompt', () => {
             instructionsPrompt: '',
             stepPrompt: '',
           },
-          base_max: {
+          [AgentTemplateTypes.base_max]: {
             id: 'base_max',
             displayName: 'Base Max Agent',
             outputMode: 'last_message',
@@ -397,7 +400,7 @@ describe('mainPrompt', () => {
       clientSessionId: 'test-session',
       onResponseChunk: () => {},
       localAgentTemplates: {
-        base: {
+        [AgentTemplateTypes.base]: {
           id: 'base',
           displayName: 'Base Agent',
           outputMode: 'last_message',
@@ -411,8 +414,8 @@ describe('mainPrompt', () => {
           instructionsPrompt: '',
           stepPrompt: '',
         },
-        base_max: {
-          id: 'base_max',
+        [AgentTemplateTypes.base_max]: {
+          id: 'base-max',
           displayName: 'Base Max Agent',
           outputMode: 'last_message',
           inputSchema: {},

backend/src/__tests__/parent-instructions.test.ts

@@ -1,10 +1,13 @@
+import {
+  AgentTemplateTypes,
+  type AgentState,
+} from '@codebuff/common/types/session-state'
 import { describe, expect, it } from 'bun:test'
 
 import { assembleLocalAgentTemplates } from '../templates/agent-registry'
 import { collectParentInstructions } from '../templates/strings'
 
 import type { DynamicAgentTemplate } from '@codebuff/common/types/dynamic-agent-template'
-import type { AgentState } from '@codebuff/common/types/session-state'
 import type {
   FileTreeNode,
   ProjectFileContext,
@@ -64,7 +67,8 @@ describe('Parent Instructions Injection', () => {
         parentInstructions: {
           researcher:
             'Spawn knowledge-keeper when you find documentation gaps.',
-          file_picker: 'Spawn knowledge-keeper when you discover missing docs.',
+          [AgentTemplateTypes.file_picker]:
+            'Spawn knowledge-keeper when you discover missing docs.',
         },
         systemPrompt: 'You are a test agent.',
         instructionsPrompt: 'Process the user request.',

common/src/__tests__/dynamic-agent-template-schema.test.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'bun:test'
+import { AgentTemplateTypes } from 'src/types/session-state'
 
 import {
   DynamicAgentConfigSchema,
@@ -362,11 +363,11 @@ describe('DynamicAgentConfigSchema', () => {
   describe('Parent Instructions Runtime Validation', () => {
     it('should validate parent instructions with valid agent IDs', () => {
       const parentInstructions = {
-        researcher: 'Spawn when you need research',
-        file_picker: 'Spawn when you need files',
-        custom_agent: 'Spawn for custom tasks',
+        [AgentTemplateTypes.researcher]: 'Spawn when you need research',
+        [AgentTemplateTypes.file_picker]: 'Spawn when you need files',
+        'custom-agent': 'Spawn for custom tasks',
       }
-      const dynamicAgentIds = ['custom_agent']
+      const dynamicAgentIds = ['custom-agent']
       const result = validateParentInstructions(
         parentInstructions,
         dynamicAgentIds,