Skip to content

Commit 5cc7cc5

Browse files
committed
Add loading message
Add dev revision for manifest
1 parent f506454 commit 5cc7cc5

File tree

7 files changed

+45
-9
lines changed

7 files changed

+45
-9
lines changed

src/addons/cb.panel.files/addon-built.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/client/core/app.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,11 @@ box, session, addons, box, files, commands, menu, tabs, panels, operations, loca
6666
});
6767

6868
// Application manifest
69-
$(window.applicationCache).bind('checking downloading', function(e) {
70-
loading.show();
69+
$(window.applicationCache).bind('downloading', function(e) {
70+
loading.show("Downloading new application cache");
71+
});
72+
$(window.applicationCache).bind('checking', function(e) {
73+
loading.show("Checking new application cache version");
7174
});
7275
$(window.applicationCache).bind('noupdate cached obsolete error', function(e) {
7376
loading.stop();
@@ -141,7 +144,7 @@ box, session, addons, box, files, commands, menu, tabs, panels, operations, loca
141144

142145
// Check update
143146
hr.Offline.checkUpdate();
144-
}));
147+
}), "Loading add-ons");
145148
}
146149
return Application.__super__.finish.apply(this, arguments);
147150
},

src/client/resources/stylesheets/main.less

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,19 @@ body {
7777
top: 50%;
7878
left: 50%;
7979
}
80+
81+
.cb-loading-message {
82+
position: absolute;
83+
width: 200px;
84+
height: 60px;
85+
line-height: 60px;
86+
font-size: 26px;
87+
margin-left: -100px;
88+
margin-top: -30px;
89+
top: 50%;
90+
left: 50%;
91+
text-align: center;
92+
color: rgb(94, 158, 243);
93+
}
8094
}
8195
}

src/client/resources/templates/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<!-- Body -->
1919
<div class="cb-body"></div>
2020
<div class="cb-alerts"></div>
21-
<div class="cb-loading-alert"><div class="cb-loadings-spinner"></div></div>
21+
<div class="cb-loading-alert"><div class="cb-loadings-spinner"></div><div class="cb-loading-message"></div></div>
2222
</div>
2323
<% } else { %>
2424
<div id="codebox">

src/client/utils/loading.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,32 @@
11
define([
2-
'jQuery'
3-
], function ($) {
2+
'jQuery',
3+
'underscore'
4+
], function ($, _) {
45
return {
5-
show: function(p) {
6+
show: function(p, message) {
67
$(".cb-loading-alert").show();
78

9+
if (_.isString(p)) {
10+
message = p;
11+
p = null;
12+
}
13+
14+
if (message) {
15+
$(".cb-loading-alert .cb-loading-message").html(message);
16+
}
17+
818
if (p) {
919
p.fin(function() {
1020
$(".cb-loading-alert").hide();
21+
$(".cb-loading-alert .cb-loading-message").html("");
1122
});
1223
}
1324

1425
return p;
1526
},
1627
stop: function() {
1728
$(".cb-loading-alert").hide();
29+
$(".cb-loading-alert .cb-loading-message").html("");
1830
}
1931
};
2032
});

src/core/cb.offline/main.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ function setup(options, imports, register) {
1212
var logger = imports.logger.namespace("offline");
1313

1414
var manifest = new Manifest();
15+
var startTime = Date.now();
1516

1617
// Disable auth for the manifest file
1718
server.disableAuth("/manifest.appcache");
@@ -25,6 +26,8 @@ function setup(options, imports, register) {
2526
return addonName+":"+addon.infos.version;
2627
}).sort().join("-")).toString();
2728

29+
if (options.dev) revision = revision+"-"+startTime;
30+
2831
// Clear manifest
2932
return manifest.clear(revision);
3033
}).then(function() {

src/core/codebox.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,11 @@ var start = function(config) {
170170
"./cb.export",
171171

172172
// Offline manifest
173-
"./cb.offline",
173+
{
174+
packagePath: "./cb.offline",
175+
176+
dev: config.dev
177+
},
174178

175179
// Search
176180
"./cb.search",

0 commit comments

Comments
 (0)