Refactor some moduels and fix some bugs

Author: SamyPesse

addons/aceeditor/addon-built.js

@@ -7,7 +7,7 @@ define([
     var $ = codebox.require("jQuery");
     var commands = codebox.require("core/commands");
     var tabs = codebox.require("utils/tabs");
-    var settings = codebox.require("utils/settings");
+    var settings = codebox.require("core/settings");
     var files = codebox.require("core/files");
     var config = codebox.require("config");
 

addons/aceeditor/client.js

@@ -2,7 +2,7 @@ define(["views/dialog"], function(InstallerDialog) {
     var commands = codebox.require("core/commands");
     var app = codebox.require("core/app");
     var dialogs = codebox.require("utils/dialogs");
-    var settings = codebox.require("utils/settings");
+    var settings = codebox.require("core/settings");
 
     // Add settings
     settings.add({

addons/manager/addon-built.js

@@ -3,7 +3,7 @@ define([
 ], function() {
     var _ = codebox.require("underscore");
     var DialogView = codebox.require("views/dialogs/base");
-    var settings = codebox.require("utils/settings");
+    var settings = codebox.require("core/settings");
 
     var SettingsDialog = DialogView.extend({
         className: "addon-settings-dialog modal fade",

addons/manager/client.js

@@ -5,8 +5,9 @@ define([
     'core/box',
     'core/session',
     'core/addons',
-    'core/box'
-], function (hr, url, dialogs, box, session, addons, box) {
+    'core/box',
+    'core/files'
+], function (hr, url, dialogs, box, session, addons, box, files) {
 
     // Define base application
     var Application = hr.Application.extend({
@@ -63,6 +64,9 @@ define([
                     addons.on("add", function(addon) {
                         addon.load();
                     });
+
+                    // Open root files
+                    files.open(box.root);
                 });
             }
             return Application.__super__.finish.apply(this, arguments);

addons/settings/addon-built.js

@@ -3,13 +3,14 @@ define([
     'underscore',
     'hr/hr',
     'models/file',
+    'core/user',
     'core/box',
-    'utils/settings',
+    'core/settings',
     'utils/dialogs',
     'utils/tabs',
     'views/tabs/file',
     'views/files/base'
-], function(Q, _, hr, File, box, settings, dialogs, tabs, FileTab) {
+], function(Q, _, hr, File, user, box, settings, dialogs, tabs, FileTab) {
     var logging = hr.Logger.addNamespace("files");
 
     // Settings for files manager
@@ -18,6 +19,7 @@ define([
         'title': "Files",
         'fields': {}
     });
+    var userSettings = user.settings("files");
 
     // Files handlers map
     var handlers = {};
@@ -40,7 +42,7 @@ define([
                 var tab = manager.getActiveTabByType("directory");
                 if (tab != null && !manager.checkTabExists(path)) {
                     // Change current tab to open the file
-                    tab.view.load(path);
+                    tab.view.load(path, handler);
                 } else {
                     // Add new tab
                     tabs.open(FileTab, {
@@ -68,7 +70,7 @@ define([
     // Get handler for a file
     var getHandlers = function(file, defaultHandler) {
         return _.filter(handlers, function(handler) {
-            return handler.valid(file);
+            return userSettings.get(handler.id, true) && handler.valid(file);
         });
     };
 

addons/settings/views/dialog.js

@@ -3,7 +3,7 @@ define([
     'jQuery',
     'underscore',
     'core/user',
-    'utils/settings'
+    'core/settings'
 ],function(hr, $, _, user, settings) {
     var logging = hr.Logger.addNamespace("search");