Use cowsay.char_names instead of hard-coded animal list

Author: RahwaZeslusHaile

implement-cowsay/cowsay_script.py

@@ -1,39 +1,38 @@
-#!/usr/bin/env python3
 import argparse
 import cowsay
 import sys
 
-def main():
-    parser = argparse.ArgumentParser(
-        description="Make animals say things"
-    )
-    parser.add_argument(
-        "message", nargs="+", help="The message to say."
-    )
-    parser.add_argument(
-        "--animal",
-        default="cow",
-        help="The animal to be saying things."
-    )
-
-    args = parser.parse_args()
-
-    text = " ".join(args.message)
-    animal = args.animal  
-
-    supported_animals = [
-        "beavis", "cheese", "cow", "daemon", "dragon", "fox",
-        "ghostbusters", "kitty", "meow", "miki", "milk", "octopus",
-        "pig", "stegosaurus", "stimpy", "trex", "turkey", "turtle", "tux"
-    ]
-
-    if animal not in supported_animals:
-        print(f"usage: cowsay [-h] [--animal {{{','.join(supported_animals)}}}] message [message ...]")
-        print(f"cowsay: error: argument --animal: invalid choice: '{animal}' (choose from {','.join(supported_animals)})")
-        sys.exit(1)
-
-    output = cowsay.get_output_string(animal, text)
-    print(output)
-
-if __name__ == "__main__":
-    main()
+parser = argparse.ArgumentParser(
+    prog="cowsay",
+    description="Make animals say things"
+)
+
+parser.add_argument(
+    "--animal",
+    choices=cowsay.char_names,
+    default="cow",
+    help="The animal to be saying things."
+)
+
+parser.add_argument(
+    "--list-animals",
+    action="store_true",
+    help="List available animals and exit."
+)
+
+parser.add_argument(
+    "message",
+    nargs="*",
+    help="The message for the animal to say."
+)
+
+args = parser.parse_args()
+
+if args.list_animals:
+    print("\n".join(cowsay.char_names))
+    sys.exit(0)
+
+if not args.message:
+    parser.error("the following arguments are required: message")
+
+getattr(cowsay, args.animal)(" ".join(args.message))

implement-cowsay/requirements.txt

@@ -0,0 +1 @@
+cowsay