From 049a2815425a0eb822db4c9aee5e7f50515587e3 Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Wed, 4 Mar 2026 18:39:50 +0000 Subject: [PATCH 1/6] Implement character counting in countChar function Fix countChar function to correctly count occurrences of a character in a string. --- Sprint-3/2-practice-tdd/count.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Sprint-3/2-practice-tdd/count.js b/Sprint-3/2-practice-tdd/count.js index 95b6ebb7d4..cabbff63b0 100644 --- a/Sprint-3/2-practice-tdd/count.js +++ b/Sprint-3/2-practice-tdd/count.js @@ -1,5 +1,12 @@ function countChar(stringOfCharacters, findCharacter) { return 5 + let count = 0; + for (let i = 0; i < stringOfCharacters.length; i++) { + if (stringOfCharacters[i] === findCharacter) { + count++; + } + } + return count; } module.exports = countChar; From 0f76821fe374b451719fbbb9aa9a2a4f73bb5ba8 Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Wed, 4 Mar 2026 18:42:06 +0000 Subject: [PATCH 2/6] Add test for character not found in string --- Sprint-3/2-practice-tdd/count.test.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Sprint-3/2-practice-tdd/count.test.js b/Sprint-3/2-practice-tdd/count.test.js index 179ea0ddf7..198f4f9931 100644 --- a/Sprint-3/2-practice-tdd/count.test.js +++ b/Sprint-3/2-practice-tdd/count.test.js @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. +test("should return 0 when character does not exist in the string", () => { + const str = "hello world"; + const char = "x"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); From 37165730542066e61c1cdbb4c86a4a44b41a2f5b Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Wed, 4 Mar 2026 18:44:21 +0000 Subject: [PATCH 3/6] Implement getOrdinalNumber function logic --- Sprint-3/2-practice-tdd/get-ordinal-number.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.js b/Sprint-3/2-practice-tdd/get-ordinal-number.js index f95d71db13..db5e046905 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.js @@ -1,5 +1,19 @@ function getOrdinalNumber(num) { return "1st"; + const lastDigit = num % 10; + const lastTwoDigits = num % 100; + if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { + return num + "th"; + } + if (lastDigit === 1) { + return num + "st"; + } else if (lastDigit === 2) { + return num + "nd"; + } else if (lastDigit === 3) { + return num + "rd"; + } else { + return num + "th"; + } } module.exports = getOrdinalNumber; From cad1f0d9468ec8d2e5ad5452ec19375bb98140e8 Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Thu, 5 Mar 2026 14:04:30 +0000 Subject: [PATCH 4/6] Add tests for ordinal number suffixes --- .../2-practice-tdd/get-ordinal-number.test.js | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index adfa58560f..a9c6a52252 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,24 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); + +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(42)).toEqual("42nd"); + expect(getOrdinalNumber(782)).toEqual("782nd"); +}); + +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(93)).toEqual("93rd"); + expect(getOrdinalNumber(7253)).toEqual("7253rd"); +}); + +test("should append 'th' for numbers ending with numbers 0, 4-9 and numbers whose last two digits are 11, 12, or 13", () => { + expect(getOrdinalNumber(11)).toEqual("11th"); + expect(getOrdinalNumber(12)).toEqual("12th"); + expect(getOrdinalNumber(13)).toEqual("13th"); + expect(getOrdinalNumber(20)).toEqual("20th"); + expect(getOrdinalNumber(75)).toEqual("75th"); + expect(getOrdinalNumber(567)).toEqual("567th"); +}); From f9bca9560c3eadcd376eb7b6c7b3e9f0f376ac02 Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Thu, 5 Mar 2026 14:06:20 +0000 Subject: [PATCH 5/6] Refactor repeatStr to use parameters and add error handling Refactor repeatStr function to accept parameters for string and count, and add error handling for invalid count. --- Sprint-3/2-practice-tdd/repeat-str.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Sprint-3/2-practice-tdd/repeat-str.js b/Sprint-3/2-practice-tdd/repeat-str.js index 3838c7b003..8ec0b8a4c6 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.js +++ b/Sprint-3/2-practice-tdd/repeat-str.js @@ -1,5 +1,8 @@ -function repeatStr() { - return "hellohellohello"; +//function repeatStr() { +// return "hellohellohello"; +function repeatStr(str, count) { + if (count >= 0) return str.repeat(count); + else throw new Error("Invalid format: count cannot be"); } module.exports = repeatStr; From 164b190239c727e06c13bccb4d4a4236c1ff1f96 Mon Sep 17 00:00:00 2001 From: Khaliun Baatarkhuu Date: Thu, 5 Mar 2026 14:08:50 +0000 Subject: [PATCH 6/6] Add tests for repeatStr function edge cases --- Sprint-3/2-practice-tdd/repeat-str.test.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Sprint-3/2-practice-tdd/repeat-str.test.js b/Sprint-3/2-practice-tdd/repeat-str.test.js index a3fc1196c4..ea29de6fc5 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.test.js +++ b/Sprint-3/2-practice-tdd/repeat-str.test.js @@ -21,12 +21,25 @@ test("should repeat the string count times", () => { // When the repeatStr function is called with these inputs, // Then it should return the original `str` without repetition. +test("should return the original string when count is 1", () => { + expect(repeatStr("hello", 1)).toEqual("hello"); +}); + // Case: Handle count of 0: // Given a target string `str` and a `count` equal to 0, // When the repeatStr function is called with these inputs, // Then it should return an empty string. +test("should return an empty string when count is 0", () => { + expect(repeatStr("hello", 0)).toEqual(""); +}); + // Case: Handle negative count: // Given a target string `str` and a negative integer `count`, // When the repeatStr function is called with these inputs, // Then it should throw an error, as negative counts are not valid. + + +test("should throw an error when count is negative", () => { + expect(() => repeatStr("hello", -1)).toThrow(); +});