Changes done as per the review

Author: dcostaprakash

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,7 +12,11 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
- if (denominator === 0) {
+  if (denominator === 0) {
+    return false;
+  }
+  // check if both numbers are integers
+  if (!Number.isInteger(numerator) || !Number.isInteger(denominator)) {
     return false;
   }
   return Math.abs(numerator) < Math.abs(denominator);
@@ -38,7 +42,6 @@ assertEquals(isProperFraction(1, 2), true);
 assertEquals(isProperFraction(5, 1), false);
 assertEquals(isProperFraction(7, 7), false);
 
-
 //Negative fractions
 assertEquals(isProperFraction(-5, -2), false);
 assertEquals(isProperFraction(-1, -2), true);
@@ -52,7 +55,11 @@ assertEquals(isProperFraction(-1, 0), false);
 assertEquals(isProperFraction(0, 0), false);
 
 // With decimals
-assertEquals(isProperFraction(2.5, -3), true);
-assertEquals(isProperFraction(-3.4, 6.3), true);
+assertEquals(isProperFraction(2.5, -3), false);
+assertEquals(isProperFraction(-3.4, 6.3), false);
 assertEquals(isProperFraction(-7.4, 3.3), false);
 
+// Boundary cases where |Numerator| equals |Denominator|
+assertEquals(isProperFraction(7, -7), false);
+assertEquals(isProperFraction(-21, -21), false);
+assertEquals(isProperFraction(119, 119), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -11,12 +11,21 @@ test(`should return false when denominator is zero`, () => {
 });
 
 // When numerator is greater than the denominator
-test(`should return false when numerator > denominator`, () => {
+test(`should return false when |numerator| >= |denominator|`, () => {
   expect(isProperFraction(5, 3)).toEqual(false);
   expect(isProperFraction(140, 7)).toEqual(false);
   expect(isProperFraction(-16, -5)).toEqual(false);
   expect(isProperFraction(-70, 14)).toEqual(false);
   expect(isProperFraction(100, -11)).toEqual(false);
+  expect(isProperFraction(-13, -13)).toEqual(false);
+});
+
+// When the numerator or denominator is not an integer
+test(`should return false when numerator or denominator is not an integer`, () => {
+  expect(isProperFraction(-1.5, 2)).toEqual(false);
+  expect(isProperFraction(2.3, 4)).toEqual(false);
+  expect(isProperFraction(3.7, 7)).toEqual(false);
+  expect(isProperFraction(102.8, -103.2)).toEqual(false);
 });
 
 // When the fraction is correct

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -36,9 +36,10 @@ test(`Should return Invalid when given an Invalid card`, () => {
   expect(() => getCardValue("K♠♣")).toThrow("Invalid card");
   expect(() => getCardValue("QQ♥")).toThrow("Invalid card");
   expect(() => getCardValue("")).toThrow("Invalid card");
+  expect(() => getCardValue("5♡")).toThrow("Invalid card");
+  expect(() => getCardValue("Q")).toThrow("Invalid card");
 });
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-