account for non-positive integers.

RaihanSharif · RaihanSharif · commit eb0dd5f9dc6e · 2026-03-06T23:20:58.000Z
diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -12,7 +12,7 @@
 
 function isProperFraction(numerator, denominator) {
   if (denominator === 0) return false;
-  return numerator < denominator ? true : false;
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`function isProperFraction(numerator, denominator) {`
`14`	`14`	`if (denominator === 0) return false;`
`15`		`- return numerator < denominator ? true : false;`
	`15`	`+ return Math.abs(numerator) < Math.abs(denominator);`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`// The line below allows us to load the isProperFraction function into tests in other files.`