correction

Author: pathywang

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -15,12 +15,14 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-   if (angle === 90) return "Right angle";
-   if (angle < 90) return "Acute angle";
-   if (90 <angle && angle<180 ) return "Obtuse angle";
-   if (angle === 180) return "Straight angle";
-   if (180<angle && angle<360) return "Reflex angle";
-   return "Invalid angle"
+  if (typeof angle !== "number" || angle <= 0 || angle > 360) return "Invalid angle";
+
+  if (angle < 90) return "Acute angle";
+  if (angle === 90) return "Right angle";
+  if (angle < 180) return "Obtuse angle";
+  if (angle === 180) return "Straight angle";
+  if (angle < 360) return "Reflex angle"; 
+  if (angle === 360) return "Full rotation angle";
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -45,6 +47,12 @@ assertEquals(right, "Right angle");
 const acute = getAngleType(45);
 assertEquals(acute, "Acute angle");
 
+const angle1=getAngleType(89)
+assertEquals(angle1, "Acute angle");
+
+const angle2=getAngleType(-45)
+assertEquals(angle2, "Invalid angle");
+
 // Case 3: Identify Obtuse Angles:
 const obtuse = getAngleType(120);
 assertEquals(obtuse, "Obtuse angle");
@@ -61,4 +69,6 @@ assertEquals(reflex, "Reflex angle");
 assertEquals(getAngleType(367),"Invalid angle");
 
 //case 7: Identify boundary angle:
-assertEquals(getAngleType(1), "Acute angle");
+assertEquals(getAngleType(1), "Acute angle");
+
+assertEquals(getAngleType(0), "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -36,7 +36,7 @@ assertEquals(isProperFraction(1, 2), true);
 assertEquals(isProperFraction(5,5), false);
 
 //Case 3: (-3)/(-5) is a proper fraction
-assertEquals(isFinite(-3,-5), true);
+assertEquals(isProperFraction(-3,-5), true);
 
 //Case 4: (-4)/6 is a proper fraction
 assertEquals(isProperFraction(-4,6),true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -62,8 +62,9 @@ assertEquals(getCardValue("5♣"), 5);
 assertEquals(getCardValue("A♦"), 11)
 
 //Examples J Q K:, 
-assertEquals(getCardValue("Q♥"), 10)
-assertEquals(getCardValue("K♥"), 10)
+assertEquals(getCardValue("Q♣"), 10)
+assertEquals(getCardValue("K♠"), 10)
+assertEquals(getCardValue("J♣"), 10)
 
 //Examples invalid numbers:
 assertThrow(()=>getCardValue("1♥"))

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -12,7 +12,7 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
   expect(getAngleType(45)).toEqual("Acute angle");
   expect(getAngleType(89)).toEqual("Acute angle");
 });
-
+ 
 // Case 2: Right angle
 test ('should return "Right angle" when angle ===90',() => {
   expect(getAngleType(90)).toEqual("Right angle");
@@ -21,6 +21,7 @@ test ('should return "Right angle" when angle ===90',() => {
 test ('should return "Obtuse angle" when (90<angle && angle <180)',() => {
   expect(getAngleType(135)).toEqual("Obtuse angle");
 })
+
 // Case 4: Straight angle
 test ('should return "Straight angle" when angle ===180',() => {
   expect(getAngleType(180)).toEqual("Straight angle");
@@ -32,6 +33,17 @@ test ('should return "Obtuse angle" when (180<angle && angle <360)',() => {
 })
 
 // Case 6: Invalid angles
+
+test('should return "Full rotation angle" when (angle=360)', ()=> {
+  expect(getAngleType(360)).toEqual("Full rotation angle");
+})
+
 test('should return "Invalid angle"when (angle>=360)', ()=> {
-  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(1012)).toEqual("Invalid angle");
 })
+
+
+test('should return "Invalid angle" when angle <= 0', () => {
+  expect(getAngleType(-5)).toEqual("Invalid angle");
+  expect(getAngleType(-10)).toEqual("Invalid angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -12,17 +12,25 @@ test(`should return false when denominator is zero`, () => {
 //case:absolute numerator is bigger than absolute denominator
 test ('should return false when numerator absolute is bigger than denominator absolute',() => {
   expect(isProperFraction(5, -4)).toEqual(false);
-})
+  expect(isProperFraction(-5, 4)).toEqual(false);
+  expect(isProperFraction(-5, -4)).toEqual(false);
+  expect(isProperFraction(5, 4)).toEqual(false);
+  });
 
 //case:numerator is the same as denominator
 test('should return false if numerator is the same as denominator', () =>{
   expect(isProperFraction(-9,-9)).toEqual(false)
+  expect(isProperFraction(4,4)).toEqual(false)
 })
 
 //case: absolute numerator is less than absolute denominator
 test ('should return true when numerator absolute is less than denominator absolute',() => {
-  expect(isProperFraction(3,-8)).toEqual(true);
-})
+  expect(isProperFraction(3, 8)).toEqual(true);
+    expect(isProperFraction(-3, 8)).toEqual(true);
+    expect(isProperFraction(3, -8)).toEqual(true);
+    expect(isProperFraction(-3, -8)).toEqual(true);
+  });
+
 
 //case: numerator is zero
 test(`should return true when nominator is zero`, () => {