Handle negative proper fractions and add tests

Author: arunkumarakilan

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -13,11 +13,9 @@
 function isProperFraction(numerator, denominator) {
   if (denominator === 0) {
     return false;
-  } else if (numerator < denominator) {
-    return true;
-  } else {
-    return false;
-  }
+  } {
+      return Math.abs(numerator) < Math.abs(denominator);
+  } 
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -41,6 +39,6 @@ assertEquals(isProperFraction(5, 4), false);
 assertEquals(isProperFraction(3, 3), false);
 assertEquals(isProperFraction(0, 5), true);
 assertEquals(isProperFraction(1, 0), false);
-assertEquals(isProperFraction(-3, 2), true);
-assertEquals(isProperFraction(2, -5), false);
-assertEquals(isProperFraction(-2, -3), false);
+assertEquals(isProperFraction(-1, 2), true);
+assertEquals(isProperFraction(1, -2), true);
+assertEquals(isProperFraction(-1, -2), true);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -21,11 +21,11 @@ test(`should return false when numerator is equals to denominator`, () => {
   expect(isProperFraction(3, 3)).toEqual(false);
 });
 test(`should return true when denominator is greater than negative numerator`, () => {
-  expect(isProperFraction(-3, 2)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true);
 });
 test(`should return false when numerator is greater than denominator`, () => {
-  expect(isProperFraction(2, -5)).toEqual(false);
+  expect(isProperFraction(1, -2)).toEqual(true);
 });
 test(`should return false when negative numerator is greater than negative denominator`, () => {
-  expect(isProperFraction(-2, -3)).toEqual(false);
+  expect(isProperFraction(-1, -2)).toEqual(true);
 });