updated 2-is-proper-function-test.js to make test description clearer also formatted with Prettier

Author: AngelaMcLeary

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -10,14 +10,14 @@
 // After you have implemented the function, write tests to cover all the cases, and
 // execute the code to ensure all tests pass.
 
-  function isProperFraction(numerator, denominator) {
+function isProperFraction(numerator, denominator) {
   // Denominator cannot be 0 because it won't make a fraction.
- if (denominator === 0) {
-        return false;
-    }
-    // Compare absolute values to eliminate negative values
-    //Proper fraction = absolute value of numerator < absolute value of denominator
-    return Math.abs(numerator) < Math.abs(denominator);
+  if (denominator === 0) {
+    return false;
+  }
+  // Compare absolute values to eliminate negative values
+  //Proper fraction = absolute value of numerator < absolute value of denominator
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -36,7 +36,7 @@ function assertEquals(actualOutput, targetOutput) {
 // What combinations of numerators and denominators should you test?
 
 // Example: 1/2 is a proper fraction
-assertEquals(isProperFraction(1, 2), true);
+assertEquals(isProperFraction(1, 0), false);
 assertEquals(isProperFraction(2, 1), false);
+assertEquals(isProperFraction(1, 2), true);
 assertEquals(isProperFraction(-1, -2), true);
-assertEquals(isProperFraction(1, 0), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -9,14 +9,14 @@ test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
 
-test(`should return true when denominator is greater than numerator (2)`, () => {
-  expect(isProperFraction(1, 2)).toEqual(true);
+test("should return false when absolute numerator is greater than or equal to absolute denominator", () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
 });
 
-test(`should return false when denominator is smaller than the numerator (1)`, () => {
-  expect(isProperFraction(2, 1)).toEqual(false);
+test("should return true when absolute numerator is less than absolute denominator", () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
 });
 
-test(`should return true when both values are valid numbers`, () => {
+test("should correctly handle negative numbers using absolute values", () => {
   expect(isProperFraction(-1, -2)).toEqual(true);
-});
+});