re improved the task

Author: KKtech06

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,48 +22,59 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  const validSuits = ["♠", "♣", "♥", "♦"];
-
-  if (typeof card !== "string" || card.length < 2) {
-    throw new Error("Invalid card");
-  }
-
-  const suit = card.slice(-1);
   const rank = card.slice(0, -1);
-
-  if (!validSuits.includes(suit)) {
-    throw new Error("invalid card");
+  const suit = card.slice(-1);
+  const validSuits = ["♠", "♥", "♦", "♣"];
+  const validRanks = [
+    "A",
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+    "10",
+    "J",
+    "Q",
+    "K",
+  ];
+
+  if (!validSuits.includes(suit) || !validRanks.includes(rank)) {
+    throw new Error("Invalid card");
   }
-
   if (rank === "A") {
     return 11;
   }
-
   if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
-
-  const numberValue = Number(rank);
-
-  if (!Number.isNaN(numberValue) && numberValue >= 2 && numberValue <= 10) {
-    return numberValue;
-  }
-
-  throw new Error("Invalid card");
+  return parseInt(rank);
 }
 
-module.exports = getCardValue;
-
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
+module.exports = getCardValue;
 
 // Helper functions to make our assertions easier to read.
+function assertEquals(actualOutput, targetOutput) {
+  console.assert(
+    actualOutput === targetOutput,
+    `Expected ${actualOutput} to equal ${targetOutput}`
+  );
+}
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
+assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
+try {
+  getCardValue("invalid");
 
-// This line will not be reached if an error is thrown as expected
+  // This line will not be reached if an error is thrown as expected
+  console.error("Error was not thrown for invalid card");
+} catch (e) {}
 
 // What other invalid card cases can you think of?