added additional tests to check for a properr fraction and implemented the function accordingly

Author: alexandru-pocovnicu

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,9 +8,18 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (Math.abs(numerator) < Math.abs(denominator)) {
     return true;
   }
+  if (
+    Math.abs(numerator) > Math.abs(denominator) ||
+    numerator === denominator
+  ) {
+    return false;
+  }
+  if(Number.isNaN(numerator) || Number.isNaN(denominator)){
+    throw new Error("Not a number")
+  }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -46,14 +55,38 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
+assertEquals(negativeFraction, true);
 // ====> complete with your assertion
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
+assertEquals(equalFraction, false);
 // ====> complete with your assertion
 
 // Stretch:
 // What other scenarios could you test for?
+
+//Both Numerator and Denominator are negative check:
+// Input: numerator = -4, denominator = -3
+// target output: false
+// Explanation:The fraction -4/-3 is not a proper fraction because the absolute value o the numerator is bigger than the absolute value of the denominator
+const bothNegativeFraction = isProperFraction(-4, -3);
+assertEquals(bothNegativeFraction, false);
+
+//Numerator is bigger than the negative Denominator's absolute value:
+// Input: numerator = 4, denominator = -9
+// target output: true
+// Explanation:The fraction 4/-9 is  a proper fraction because the absolute value of the denominator is smaller than the the value of the numerator
+const negativeDenominator=isProperFraction(4,-9)
+assertEquals(negativeDenominator,true)
+
+
+
+
+
+//got stuck on this one, don't know how to test
+//      const notANumber=isProperFraction("a",2)
+ //      assertEquals(negativeFraction, "Not a number");