refactor getCard function and add more test case

Author: Ofonimeedak

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,12 +22,7 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  if (
-    typeof card !== "string" ||
-    card.length < 2 ||
-    card.length > 3 ||
-    card.includes(" ")
-  ) {
+  if (typeof card !== "string") {
     throw new Error("Invalid string");
   }
 
@@ -56,10 +51,9 @@ function getCardValue(card) {
     return 11;
   } else if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
-  } else if (rank) {
+  } else {
     return Number(rank);
   }
-  throw new Error("Invalid string");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -16,3 +16,21 @@ test("should return false when denominator is zero", () => {
   expect(isProperFraction(-1, 0)).toEqual(false);
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+test("should return false when denominator and numerator have both the same negative and positive integer", () => {
+  expect(isProperFraction(-1, 1)).toEqual(false);
+  expect(isProperFraction(1, -1)).toEqual(false);
+});
+
+test(`should return true when denominator is > numerator `, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(1, 10000)).toEqual(true);
+
+  expect(isProperFraction(1e2, 1e3)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true);
+});
+
+test("should return false when denominator < numerator", () => {
+  expect(isProperFraction(1e4, 1)).toEqual(false);
+  expect(isProperFraction(100, 2)).toEqual(false);
+});