Skip to content

Commit ae3b75a

Browse files
committed
feat: remove dead code and redundant operations for better readability
1 parent c13bb37 commit ae3b75a

File tree

1 file changed

+35
-15
lines changed

1 file changed

+35
-15
lines changed

Sprint-3/3-dead-code/exercise-2.js

Lines changed: 35 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,48 @@
11
// Remove the unused code that does not contribute to the final console log
22
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.
33

4+
// const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
5+
// const capitalisedPets = pets.map((pet) => pet.toUpperCase());
6+
// const petsStartingWithH = pets.filter((pet) => pet[0] === "h");
7+
8+
// function logPets(petsArr) {
9+
// petsArr.forEach((pet) => console.log(pet));
10+
// }
11+
12+
// function countAndCapitalisePets(petsArr) {
13+
// const petCount = {};
14+
15+
// petsArr.forEach((pet) => {
16+
// const capitalisedPet = pet.toUpperCase();
17+
// if (petCount[capitalisedPet]) {
18+
// petCount[capitalisedPet] += 1;
19+
// } else {
20+
// petCount[capitalisedPet] = 1;
21+
// }
22+
// });
23+
// return petCount;
24+
// }
25+
26+
// const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);
27+
28+
// console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
29+
30+
31+
32+
433
const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
5-
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
634
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");
735

8-
function logPets(petsArr) {
9-
petsArr.forEach((pet) => console.log(pet));
10-
}
11-
12-
function countAndCapitalisePets(petsArr) {
36+
function countPets(pets) {
1337
const petCount = {};
1438

15-
petsArr.forEach((pet) => {
39+
pets.forEach((pet) => {
1640
const capitalisedPet = pet.toUpperCase();
17-
if (petCount[capitalisedPet]) {
18-
petCount[capitalisedPet] += 1;
19-
} else {
20-
petCount[capitalisedPet] = 1;
21-
}
41+
petCount[capitalisedPet] = (petCount[capitalisedPet] || 0) + 1;
2242
});
23-
return petCount;
43+
44+
return petCount ;
2445
}
2546

26-
const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);
2747

28-
console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
48+
console.log(countPets(petsStartingWithH)); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log

0 commit comments

Comments
 (0)