rewrite all tests based on mathematical definition of proper fractions

Author: XiaoQuark

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -10,9 +10,7 @@
 // After you have implemented the function, write tests to cover all the cases, and
 // execute the code to ensure all tests pass.
 
-function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
-}
+function isProperFraction(numerator, denominator) {}
 
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
@@ -34,14 +32,18 @@ assertEquals(isProperFraction(1, 2), true);
 
 assertEquals(isProperFraction(9, 10), true);
 
-assertEquals(isProperFraction(0, 7), false);
+assertEquals(isProperFraction(-6, 8), true);
+
+assertEquals(isProperFraction(-2, -3), true);
+
+assertEquals(isProperFraction(3.5, 6), true);
 
-assertEquals(isProperFraction(5, 0), false);
+assertEquals(isProperFraction(4, 4.67), true);
 
-assertEquals(isProperFraction(3.5, 6), false);
+assertEquals(isProperFraction(7, 0), false);
 
 assertEquals(isProperFraction(2, 1), false);
 
-assertEquals(isProperFraction(9, 3), false);
+assertEquals(isProperFraction(-9, -3), false);
 
-assertEquals(isProperFraction(4, 4.67), false);
+assertEquals(isProperFraction(-5.68, 0), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -6,34 +6,35 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // Special case: numerator is zero
 
-test(`should return true when numerator < denominator and both are integers`, () => {
+test(`should return true when the absolute value of the numerator is less than the absolute value of the denominator and the denominator is not 0`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
-  expect(isProperFraction(3, 9)).toEqual(true);
-  expect(isProperFraction(99, 100)).toEqual(true);
+  expect(isProperFraction(3.5, 4)).toEqual(true);
+  expect(isProperFraction(-99, -100)).toEqual(true);
+  expect(isProperFraction(0, -5)).toEqual(true);
+  expect(isProperFraction(8, 12.5)).toEqual(true);
+  expect(isProperFraction(-6, 12)).toEqual(true);
 });
 
-test(`should return false when denominator = zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
-  expect(isProperFraction(5, 0)).toEqual(false);
+test(`should return false when the denominator is equal to zero`, () => {
+  expect(isProperFraction(-1, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+  expect(isProperFraction(15, 0)).toEqual(false);
+  expect(isProperFraction(6.4, 0)).toEqual(false);
+  expect(isProperFraction(-8.5, 0)).toEqual(false);
 });
 
-test(`should return false when numerator = zero`, () => {
-  expect(isProperFraction(0, 5)).toEqual(false);
-  expect(isProperFraction(0, 7)).toEqual(false);
-});
-
-test(`should return false when numerator > denominator`, () => {
+test(`should return false when the absolute value of the numerator is greater than the absolute value of the denominator`, () => {
   expect(isProperFraction(3, 2)).toEqual(false);
-  expect(isProperFraction(9, 3)).toEqual(false);
-  expect(isProperFraction(36, 7)).toEqual(false);
-});
-
-test(`should return false when either numerator or denominator or both are float numbers`, () => {
-  expect(isProperFraction(1.5, 2)).toEqual(false);
-  expect(isProperFraction(6, 7.1)).toEqual(false);
-  expect(isProperFraction(3.56, 2.4)).toEqual(false);
+  expect(isProperFraction(-9, 3)).toEqual(false);
+  expect(isProperFraction(-15, -4)).toEqual(false);
+  expect(isProperFraction(36, -5)).toEqual(false);
+  expect(isProperFraction(3.8, 2.7)).toEqual(false);
 });
 
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
+test(`should return false when the absolute value of the numerator is equal to the absolute value of the denominator`, () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+  expect(isProperFraction(-19, -19)).toEqual(false);
+  expect(isProperFraction(7.45, 7.45)).toEqual(false);
+  expect(isProperFraction(67, -67)).toEqual(false);
+  expect(isProperFraction(-8, 8)).toEqual(false);
 });