Completed 2-is-proper-fraction

Author: libanj0161

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,6 +12,8 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
+  if (denominator === 0) return false;
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,18 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+test(`for positive`, () => {
+  expect(isProperFraction(6, 7)).toEqual(true);
+  expect(isProperFraction(2, 4)).toEqual(true);
+});
+
+test(`should return false for improper fractions`, () => {
+  expect(isProperFraction(8, 6)).toEqual(false);
+  expect(isProperFraction(4, 2)).toEqual(false);
+});
+
+test(`negative combinations`, () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+  expect(isProperFraction(-2, 0)).toEqual(false);
+});