Skip to content

Commit 9fd83a0

Browse files
committed
refactor first test, splitting it into two, for more explicit testing about cases with numerator = 0
1 parent 8a750dd commit 9fd83a0

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,18 @@ test(`should return true when the absolute value of the numerator is less than t
1111
expect(isProperFraction(1, -3)).toEqual(true);
1212
expect(isProperFraction(3.5, 4)).toEqual(true);
1313
expect(isProperFraction(-99, -100)).toEqual(true);
14-
expect(isProperFraction(0, -5)).toEqual(true);
15-
expect(isProperFraction(0, 56)).toEqual(true);
1614
expect(isProperFraction(8, 12.5)).toEqual(true);
1715
expect(isProperFraction(-6, 12)).toEqual(true);
1816
expect(isProperFraction(0.03, 0.1)).toEqual(true);
1917
});
2018

19+
test(`should return true when numerator is equal to 0 and denominator is either positive or negative`, () => {
20+
expect(isProperFraction(0, -5)).toEqual(true);
21+
expect(isProperFraction(0, 56)).toEqual(true);
22+
expect(isProperFraction(0, 0.1)).toEqual(true);
23+
expect(isProperFraction(0, -8.9)).toEqual(true);
24+
});
25+
2126
test(`should return false when the denominator is equal to zero`, () => {
2227
expect(isProperFraction(-1, 0)).toEqual(false);
2328
expect(isProperFraction(0, 0)).toEqual(false);

0 commit comments

Comments
 (0)