Format file with Prettier and revise test descriptions

Author: RomanSanaye

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,24 +22,24 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-   if (typeof card !== "string") {
+  if (typeof card !== "string") {
     throw new Error("Invalid card");
   }
   let rank = card.slice(0, -1); // Get everything except the last character
-  let suit = card.slice(-1);    //  Get the last character
-  
+  let suit = card.slice(-1); //  Get the last character
+
   const validSuits = ["♠", "♥", "♦", "♣"]; // check if suit is valid
   if (!validSuits.includes(suit)) {
     throw new Error("Invalid card");
   }
 
-  if (rank === "A"){
+  if (rank === "A") {
     return 11;
-  }else if(/^[JQK]$/.test(rank)){
+  } else if (/^[JQK]$/.test(rank)) {
     return 10;
-  }else if(rank.match(/^(10|[2-9])$/)){
+  } else if (rank.match(/^(10|[2-9])$/)) {
     return Number(rank);
-  }else throw new Error("Invalid card");
+  } else throw new Error("Invalid card");
 }
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
@@ -71,28 +71,28 @@ try {
 // What other invalid card cases can you think of?
 
 try {
-  getCardValue("9X");   // invalid suit
+  getCardValue("9X"); // invalid suit
   console.error('Test failed for "9X": error was not thrown');
 } catch (e) {
   console.log('Test passed for "9X": caught error ->', e.message);
 }
 
 try {
-  getCardValue("1♠");   // invalid rank
+  getCardValue("1♠"); // invalid rank
   console.error('Test failed for "1♠": error was not thrown');
 } catch (e) {
   console.log('Test passed for "1♠": caught error ->', e.message);
 }
 
 try {
-  getCardValue("0♥");   // invalid rank
+  getCardValue("0♥"); // invalid rank
   console.error('Test failed for "0♥": error was not thrown');
 } catch (e) {
   console.log('Test passed for "0♥": caught error ->', e.message);
 }
 
 try {
-  getCardValue("ABC");  // completely wrong format
+  getCardValue("ABC"); // completely wrong format
   console.error('Test failed for "ABC": error was not thrown');
 } catch (e) {
   console.log('Test passed for "ABC": caught error ->', e.message);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -5,21 +5,26 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
+test("returns false when denominator is zero", () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
-test(`should return false when denominator is less than numerator`, () => {
-  expect(isProperFraction(2, 1)).toEqual(false);
-});
-test("should return false when numerator is zero", ()=>{
+
+test("returns false when numerator is zero", () => {
   expect(isProperFraction(0, 1)).toEqual(false);
 });
-test("should return false when numerator is a negative number", ()=>{
+
+test("returns false when numerator > denominator", () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+});
+
+test("returns false when numerator is negative", () => {
   expect(isProperFraction(-2, 2)).toEqual(false);
 });
-test("should return false when denominator is a negative number", ()=>{
+
+test("returns false when denominator is negative", () => {
   expect(isProperFraction(2, -2)).toEqual(false);
 });
-test("should return false where both numerator and denominator are negative numbers", ()=> {
+
+test("returns false when both numerator and denominator are negative", () => {
   expect(isProperFraction(-3, -4)).toEqual(false);
-})
+});