fixed the error and add throw new error if the denominator is 0 and added test as well

Author: Abduhasen

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,8 +12,8 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
-  if (Math.abs(numerator) < Math.abs(denominator)) return true;
-  else return false;
+  if (denominator === 0) throw new Error("Denominator cannot be zero");
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,24 +4,29 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 // Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(-11, 0)).toEqual(false);
-  expect(isProperFraction(0, 0)).toEqual(false);
-  expect(isProperFraction(7, 0)).toEqual(false);
+test("should Throw new error for abs(denominator) == 0", () => {
+  expect(() => isProperFraction(-11, 0)).toThrow("Denominator cannot be zero");
+  expect(() => isProperFraction(0, 0)).toThrow("Denominator cannot be zero");
+  expect(() => isProperFraction(7, 0)).toThrow("Denominator cannot be zero");
 });
 // It should return false when the numerator > the denominator
-test("should return true when numerator is 0", () => {
+test("should return false when abs(numerator) == 0", () => {
   expect(isProperFraction(0, -1)).toEqual(true);
   expect(isProperFraction(0, 3)).toEqual(true);
   expect(isProperFraction(0, -2)).toEqual(true);
 });
-test("should return true when abs(numerator) > abs(denominator)", () => {
+test("should return true when abs(numerator) < abs(denominator)", () => {
   expect(isProperFraction(-12, -19)).toEqual(true);
-  expect(isProperFraction(0, 6)).toEqual(true);
+  expect(isProperFraction(3, 6)).toEqual(true);
   expect(isProperFraction(17, -71)).toEqual(true);
 });
-test("should return false when abs(numerator) < abs(denominator)", () => {
+test("should return false when abs(numerator) > abs(denominator)", () => {
   expect(isProperFraction(-180, -109)).toEqual(false);
   expect(isProperFraction(27, 5)).toEqual(false);
   expect(isProperFraction(-29, 17)).toEqual(false);
 });
+test("should return false when abs(numerator) == abs(denominator)", () => {
+  expect(isProperFraction(9, 9)).toEqual(false);
+  expect(isProperFraction(-17, -17)).toEqual(false);
+  expect(isProperFraction(-15, 15)).toEqual(false);
+});