refactor tests: use absolute value rule for proper fractions

Author: Pretty Taruvinga

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -5,30 +5,28 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Special case: denominator is zero
-test(`should return false when denominator is zero`, () => {
+test("should return false when denominator is zero", () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
 
 // Case: numerator is zero
-test(`should return true when numerator is zero and denominator is positive`, () => {
+test("should return true when numerator is zero and denominator is positive", () => {
   expect(isProperFraction(0, 1)).toEqual(true);
 });
-test("should return true when numerator is smaller than denominator and both are positive", () => {
+
+// Proper fractions
+test("should return true when abs(numerator) < abs(denominator)", () => {
   expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true);
+  expect(isProperFraction(1, -2)).toEqual(true);
+  expect(isProperFraction(-1, -2)).toEqual(true);
 });
 
+// Improper fractions
 test("should return false when numerator is equal to denominator", () => {
   expect(isProperFraction(2, 2)).toEqual(false);
 });
 
 test("should return false when numerator is greater than denominator", () => {
   expect(isProperFraction(3, 2)).toEqual(false);
 });
-
-test("should return false when numerator is negative", () => {
-  expect(isProperFraction(-1, 2)).toEqual(false);
-});
-
-test("should return true when both numerator and denominator are negative and numerator is smaller than denominator", () => {
-  expect(isProperFraction(-1, -2)).toEqual(true);
-});