Fixed PR review

Author: Ofonimeedak

Sprint-1/1-key-exercises/1-count.js

@@ -4,5 +4,6 @@ count = count + 1;
 
 // Line 1 is a variable declaration, creating the count variable with an initial value of 0
 // Describe what line 3 is doing, in particular focus on what = is doing
-//Line 3 of the code assigns a value to the declared variable count.
+//Line 3 of the code reassigns a value to the declared variable count.
+// the programming term for this is called increment
 // The = sign is an assignment operator, without line 3, the declared variable wil be undefined.

Sprint-1/1-key-exercises/2-initials.js

@@ -5,6 +5,7 @@ let lastName = "Johnson";
 // Declare a variable called initials that stores the first character of each string.
 // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.
 
-let initials = `${firstName[0]}+${middleName}+${lastName}`;
+let initials = `${firstName[0]}${middleName[0]}${lastName[0]}`;
+console.log(initials); //CJK
 
 // https://www.google.com/search?q=get+first+character+of+string+mdn

Sprint-1/1-key-exercises/3-paths.js

@@ -9,15 +9,17 @@
 
 // (All spaces in the "" line should be ignored. They are purely for formatting.)
 
-const filePath = "/Users/mitch/cyf/Module-JS1/week-1/interpret/file.txt";
+const filePath = "/Users/mitch/cyf/Module-JS1/week-1/interpret/package.json";
 const lastSlashIndex = filePath.lastIndexOf("/");
 const base = filePath.slice(lastSlashIndex + 1);
 console.log(`The base part of ${filePath} is ${base}`);
 
 // Create a variable to store the dir part of the filePath variable
 // Create a variable to store the ext part of the variable
+const lastDotIndex = filePath.lastIndexOf(".");
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = filePath.slice(lastDotIndex + 1);
+console.log(dir);
+console.log(ext);
 
-const dir =filePath.slice(0,filePath.length-base.length-1) ;
-const ext = filePath.slice(-3);
-
-// https://www.google.com/search?q=slice+mdn
+// https://www.google.com/search?q=slice+mdn

Sprint-1/2-mandatory-errors/2.js

@@ -1,6 +1,6 @@
 // Currently trying to print the string "I was born in Bolton" but it isn't working...
- 
-// JavaScript is single-threaded because it executes tasks in a single flow using a call stack. The function was called before it was declared, 
+
+// JavaScript is single-threaded because it executes tasks in a single flow using a call stack. The function was called before it was declared,
 // It was also declared with const, which can not be hoisted to the top, like var.
 // this result to undefined.
 

Sprint-1/3-mandatory-interpret/1-percentage-change.js

@@ -19,15 +19,16 @@ console.log(`The percentage change is ${percentageChange}`);
 // 3. line 10 console.log() that logs the result to the console
 
 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-// The error in this code is coming from line 5. The wrong use of the replaceAll syntax without a separator.
+// The error in this code is coming from line 5. The wrong use of the
+// replaceAll method without a comma between the pattern and replacement in the function  argument.
 // I will fix this problem by reading the documentation, to see the right way the syntax should be written.
 //Then i will add the comma where necessary
 
 // c) Identify all the lines that are variable reassignment statements
- // line 4 and 5 are variable reassignment
+// line 4 and 5 are variable reassignment
 
 // d) Identify all the lines that are variable declarations
- // line 1,2,7,8 are all variable declaration
+// line 1,2,7,8 are all variable declaration
 
 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
-// this expression replaces the comma at the string with an empty string and the convert the string data type to a number data type
+// this expression replaces the comma at the string with an empty string and the convert the string data type to a number data type

Sprint-1/3-mandatory-interpret/2-time-format.js

@@ -14,7 +14,6 @@ console.log(result);
 // a) How many variable declarations are there in this program?
 // there are 6 variable declaration.
 
-
 // b) How many function calls are there?
 // One function call
 
@@ -29,7 +28,7 @@ console.log(result);
 
 // e) What do you think the variable result represents? Can you think of a better name for this variable?
 // the variable result represent total movie duration in hours,minute and seconds.
-// const=movieLength
+// const=movieDuration
 
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
 // this code works for all movie length and integer values.

Sprint-1/4-stretch-explore/chrome.md

@@ -23,3 +23,4 @@ What effect does calling the `prompt` function have?
 it invokes a modal window, and allows me to enter an input value
 What is the return value of `prompt`?
 it returns the value i entered "Edak"
+It will return null.

Sprint-1/4-stretch-explore/objects.md

@@ -22,4 +22,4 @@ What does the syntax `console.log` or `console.assert` mean? In particular, what
 console.log: Output a message to the console
 
 console.assert: Log an error message to the console if the first argument is false.
-`.` console is the class the . helps you to access the methods or properties of the class console.
+`.` the console stored methods.

Sprint-3/2-practice-tdd/count.js

@@ -1,5 +1,16 @@
 function countChar(stringOfCharacters, findCharacter) {
-  return 5
+  let count=0;
+  for(let i=0; i<stringOfCharacters.length; i++){
+
+    if(stringOfCharacters[i]===findCharacter){
+count++;
+    }else{
+      return 0
+    }
+  
+  }
+  return count;
 }
 
+
 module.exports = countChar;