Update isProperFraction function

Author: Oussama-Mouggal

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,7 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  return numerator > 0 && denominator > 0 && numerator < denominator;
+  return numerator >= 0 && denominator > 0 && numerator < denominator;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -46,9 +46,9 @@ assertEquals(isProperFraction(4, 4), false);
 assertEquals(isProperFraction(10, 5), false);
 assertEquals(isProperFraction(100, 99), false);
 
-// Edge cases with zero - should return false
-assertEquals(isProperFraction(0, 5), false);
-assertEquals(isProperFraction(0, 1), false);
+// Edge cases with zero numerator - should return true
+assertEquals(isProperFraction(0, 5), true);
+assertEquals(isProperFraction(0, 1), true);
 
 // Negative numbers - should return false
 assertEquals(isProperFraction(-1, 2), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -5,13 +5,14 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
 // Proper fractions - should return true
-test(`should return true for proper fractions (0 < numerator < denominator)`, () => {
+test(`should return true for proper fractions (0 <= numerator < denominator)`, () => {
   expect(isProperFraction(1, 2)).toEqual(true);
   expect(isProperFraction(3, 4)).toEqual(true);
   expect(isProperFraction(1, 5)).toEqual(true);
   expect(isProperFraction(2, 3)).toEqual(true);
   expect(isProperFraction(5, 8)).toEqual(true);
   expect(isProperFraction(1, 100)).toEqual(true);
+  expect(isProperFraction(0, 5)).toEqual(true);
 });
 
 // Improper fractions - should return false
@@ -23,11 +24,11 @@ test(`should return false for improper fractions (numerator >= denominator)`, ()
   expect(isProperFraction(100, 99)).toEqual(false);
 });
 
-// Edge cases with zero - should return false
-test(`should return false when numerator is zero`, () => {
-  expect(isProperFraction(0, 5)).toEqual(false);
-  expect(isProperFraction(0, 1)).toEqual(false);
-  expect(isProperFraction(0, 100)).toEqual(false);
+// Edge cases with zero numerator - should return true
+test(`should return true when numerator is zero and denominator is positive`, () => {
+  expect(isProperFraction(0, 5)).toEqual(true);
+  expect(isProperFraction(0, 1)).toEqual(true);
+  expect(isProperFraction(0, 100)).toEqual(true);
 });
 
 // Special case: denominator is zero