Implement getCardValue function and added tests for valid and invalid card cases

Author: ashaahmed7

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -40,25 +40,25 @@ function assertEquals(actualOutput, targetOutput) {
 assertEquals(isProperFraction(1, 2), true);
 
 // Example: 3/5 is a proper fraction
-assertEquals(properFraction(3 / 5), true);
+assertEquals(isProperFraction(3, 5), true);
 
-// Example: 1/100 is a positive fraction
-assertEquals(smallFraction(1, 100), true);
+// Example: 1/100 is a proper fraction
+assertEquals(isProperFraction(1, 100), true);
 
-// Example: 0/4 is a proper fraction with zero numerator
-assertEquals(zeroNumerator(0, 4), true);
+// Example: 5/2 is not a proper fraction
+assertEquals(isProperFraction(5, 2), false);
 
-// Example: 7/7 is an improper fraction,
-assertEquals(equalFraction(7, 7), false);
+// Example: 7/7 is an improper fraction
+assertEquals(isProperFraction(7, 7), false);
 
-// Example: 8/3 is an improper fraction,
-assertEquals(numeratorLarger(8, 3), false);
+// Example: 8/3 is an improper fraction
+assertEquals(isProperFraction(8, 3), false);
 
 // Example: 5/0 is an invalid fraction
-assertEquals(zeroDenominator(5, 0), false);
+assertEquals(isProperFraction(5, 0), false);
 
 // Example: 2/-6 is an invalid fraction
-assertEquals(negativeDenominator(2, -6), false);
+assertEquals(isProperFraction(2, -6), false);
 
 // Example: -1/4 is an invalid fraction
-assertEquals(negativeNumerator(-1, 4), false);
+assertEquals(isProperFraction(-1, 4), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -23,6 +23,14 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
+  if (!["♠", "♣", "♦", "♥"].includes(card.slice(-1)))
+    throw new Error("Invalid card rank.");
+  const rank = card.slice(0, card.length - 1);
+  if (rank === "A") return 11;
+  if (["10", "J", "Q", "K"].includes(rank)) return 10;
+  if (["2", "3", "4", "5", "6", "7", "8", "9"].includes(rank))
+    return Number(rank);
+  throw new Error("Invalid card rank.");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -41,6 +49,12 @@ function assertEquals(actualOutput, targetOutput) {
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
 
+assertEquals(getCardValue("6♥"), 6);
+
+assertEquals(getCardValue("J♣"), 10);
+
+assertEquals(getCardValue("A♦"), 11);
+
 // Handling invalid cards
 try {
   getCardValue("invalid");
@@ -50,3 +64,33 @@ try {
 } catch (e) {}
 
 // What other invalid card cases can you think of?
+
+try {
+  getCardValue("9K");
+
+  console.log("Error was not thrown for invalid card");
+} catch (error) {}
+
+try {
+  getCardValue("");
+
+  console.log("Error was not thrown for invalid card");
+} catch (error) {}
+
+try {
+  getCardValue("ABC");
+
+  console.log("Error was not thrown for invalid card");
+} catch (error) {}
+
+try {
+  getCardValue("A");
+
+  console.log("Error was not thrown for invalid card");
+} catch (error) {}
+
+try {
+  getCardValue("JK");
+
+  console.log("Error was not thrown for invalid card");
+} catch (error) {}