worked on the feedback

Author: MehrozMunir

Sprint-3/2-practice-tdd/count.js

@@ -1,8 +1,6 @@
 function countChar(stringOfCharacters, findCharacter) {
-  if (findCharacter === "")
-    return 0;
-  else
-    return stringOfCharacters.split(findCharacter).length -1;
+  if (findCharacter.length === 0) return 0;
+  else return stringOfCharacters.split(findCharacter).length - 1;
 }
 
-module.exports = countChar;
+module.exports = countChar;

Sprint-3/2-practice-tdd/count.test.js

@@ -30,7 +30,6 @@ test("should return 0 if there are no occurrences of a character", () => {
   expect(count).toEqual(0);
 });
 
-
 // Scenario 3: Single Occurrence
 // Given the input string `str`,
 // And a character `char` that exists only once within `str`.
@@ -70,15 +69,15 @@ test("should return multiple occurrences of empty spaces in the string", () => {
   expect(count).toEqual(10);
 });
 
-
 // Scenario 6: No occurrences if the char is just an empty char
 // Given the input string `str` that contains any number of characters or no characters at all,
 // And a character `char` which is empty ''.
 // When the function is called with these inputs,
 // Then it should return 0 as there is nothing to count as the char is just empty.
 
 test("should return 0 as the char is just empty", () => {
-  const str = "Hi I am a string that can be empty or not empty but I can't count empty characters.";
+  const str =
+    "Hi I am a string that can be empty or not empty but I can't count empty characters.";
   const char = "";
   const count = countChar(str, char);
   expect(count).toEqual(0);
@@ -95,4 +94,4 @@ test("should count multiple occurrences of a character", () => {
   const char = "a";
   const count = countChar(str, char);
   expect(count).toEqual(4);
-});
+});

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -2,16 +2,11 @@ function getOrdinalNumber(num) {
   let numberString = String(num);
   lastTwoCharactersNumberString = numberString.slice(-2);
   lastCharacterNumberString = numberString.slice(-1);
-  if(lastTwoCharactersNumberString === "11")
-    return num+ "th";
-  else if(lastCharacterNumberString === "1")
-    return num+ "st";
-  else if(lastCharacterNumberString === "2")
-    return num+"nd";
-  else if(lastCharacterNumberString === "3")
-    return num + "rd";
-  else
-    return num + "th";
+  if (lastTwoCharactersNumberString === "11") return num + "th";
+  else if (lastCharacterNumberString === "1") return num + "st";
+  else if (lastCharacterNumberString === "2") return num + "nd";
+  else if (lastCharacterNumberString === "3") return num + "rd";
+  else return num + "th";
 }
 
-module.exports = getOrdinalNumber;
+module.exports = getOrdinalNumber;

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -41,15 +41,14 @@ test("should append 'st' for numbers ending with 2", () => {
   expect(getOrdinalNumber(-82)).toEqual("-82nd");
 });
 
-
 // Case 4: Numbers ending with 3
 // When the number is ending with 3,
 // Then the function should return a string by appending "rd" to the number.
 test("should append 'st' for numbers ending with 3", () => {
   expect(getOrdinalNumber(3)).toEqual("3rd");
   expect(getOrdinalNumber(33)).toEqual("33rd");
   expect(getOrdinalNumber(183)).toEqual("183rd");
-    expect(getOrdinalNumber(-903)).toEqual("-903rd");
+  expect(getOrdinalNumber(-903)).toEqual("-903rd");
 });
 
 // Case 5: Numbers not ending 1, 2 and 3 except 11
@@ -63,6 +62,4 @@ test("should append 'th' for numbers not ending with 1, 2 and 3 except those end
   expect(getOrdinalNumber(1000)).toEqual("1000th");
   expect(getOrdinalNumber(87939)).toEqual("87939th");
   expect(getOrdinalNumber(-780987)).toEqual("-780987th");
-
 });
-

Sprint-3/2-practice-tdd/repeat-str.js

@@ -1,17 +1,12 @@
 function repeatStr(str, count) {
-  try{
-    if(count === 0)
-      return "";
-    else if(count === 1)
-      return str;
-    else if(count < 0)
-      throw new Error("an error is thrown");
-    else
-    return str.repeat(count);
-  }
-  catch(e){
+  try {
+    if (count === 0) return "";
+    else if (count === 1) return str;
+    else if (count < 0) throw new Error("an error is thrown");
+    else return str.repeat(count);
+  } catch (e) {
     return e.message;
   }
 }
 
-module.exports = repeatStr;
+module.exports = repeatStr;

Sprint-3/2-practice-tdd/repeat-str.test.js

@@ -47,4 +47,4 @@ test("should repeat the string count times", () => {
   const count = -2;
   const repeatedStr = repeatStr(str, count);
   expect(repeatedStr).toEqual("an error is thrown");
-});
+});