fun with fractions

Author: mjm-git185

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,8 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  numerator = Math.sign(numerator) * Math.abs(numerator);
- return (numerator < denominator )   
+ return (Math.abs(numerator) < denominator )   
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -25,7 +25,10 @@ test(`Should return a true when the (numerator < denominator)`,()=>{
 });
 test(`Should return the correct answer for negative numerators (numerator < denominator)`,()=>{
     expect(isProperFraction(-1,2)).toEqual(true)
-    expect(isProperFraction(-100,2)).toEqual(true)
     expect(isProperFraction(-7,8)).toEqual(true)
+    expect(isProperFraction(-100,2)).toEqual(false)
+    expect(isProperFraction(-60,10)).toEqual(false)
+    expect(isProperFraction(-5,4)).toEqual(false)
+
 
 });