updated test case for proper fraction function

Author: marthak1

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -10,27 +10,27 @@ test(`should return false when denominator is zero`, () => {
 });
 
 // Normal case: 
-test(`should return false when denominator is zero`, () => {
+test(`should return true in normal scenario`, () => {
   expect(isProperFraction(5, 10)).toEqual(true);
 });
 // Boundary Value
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
+test(`should return false when numerator is 0`, () => {
+  expect(isProperFraction(0, 5)).toEqual(false);
 });
 // Improper Fraction
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 1)).toEqual(false);
+test(`should return false when numerator is greater than denominator`, () => {
+  expect(isProperFraction(8, 3)).toEqual(false);
 });
 // Negative Value
-test(`should return false when denominator is zero`, () => {
+test(`should return false when numerator is negative`, () => {
   expect(isProperFraction(-3, 8)).toEqual(false);
 
 });
 // Very Small
-test(`should return false when denominator is zero`, () => {
+test(`should return true with very small values`, () => {
   expect(isProperFraction(0.0001, 999999)).toEqual(true);
 });
 // very large
-test(`should return false when denominator is zero`, () => {
+test(`should return false with very large`, () => {
   expect(isProperFraction(999999, 0.0001)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -2,7 +2,7 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getCardValue = require("../implement/3-get-card-value");
 
-// TODO: Write tests in Jest syntax to cover all possible outcomes.
+// Write tests in Jest syntax to cover all possible outcomes.
 
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
@@ -11,8 +11,17 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♠")).toEqual(11);
+});
 //   Face Cards (J, Q, K)
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♠")).toEqual(11);
+});
 //   Invalid Cards
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♠")).toEqual(11);
+});
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation: