implement 2

Author: ihortar

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -70,4 +70,4 @@ assertEquals(getAngleType(-10), "Invalid angle");
 assertEquals(getAngleType(360), "Invalid angle");
 assertEquals(getAngleType(361), "Invalid angle");
 
-console.log("All tests executed (any failures would appear above).");
+console.log("All tests passed!");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,6 +12,10 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
+  if (denominator === 0) return false;
+  if (denominator < 0) return false;
+
+  return Math.abs(numerator) < denominator;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -31,3 +35,24 @@ function assertEquals(actualOutput, targetOutput) {
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
+
+// Improper fractions (numerator > denominator)
+assertEquals(isProperFraction(2, 1), false);
+assertEquals(isProperFraction(5, 4), false);
+
+// Equal numerator/denominator is not proper
+assertEquals(isProperFraction(5, 5), false);
+
+// Zero numerator: 
+assertEquals(isProperFraction(0, 3), true);
+
+// Negative numerator:
+assertEquals(isProperFraction(-1, 2), true);
+assertEquals(isProperFraction(-3, 2), false);
+
+// Denominator edge cases
+assertEquals(isProperFraction(1, 0), false);  
+assertEquals(isProperFraction(1, -2), false); 
+assertEquals(isProperFraction(-1, -2), false);
+
+console.log ("All tests passed!")