Skip to content

Commit 560d5c6

Browse files
committed
implementation to handle boundary angles correctly with test case
1 parent 8c587a2 commit 560d5c6

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515
// execute the code to ensure all tests pass.
1616

1717
function getAngleType(angle) {
18-
if (angle < 0 || angle > 360) {
19-
return "Invalid angle";
20-
}
21-
2218
if (angle > 0 && angle < 90) {
2319
return "Acute angle";
2420
}
@@ -34,7 +30,9 @@ function getAngleType(angle) {
3430
if (angle > 180 && angle < 360) {
3531
return "Reflex angle";
3632
}
37-
33+
if (angle === 360) {
34+
return "Straight angle";
35+
}
3836
return "Invalid angle";
3937
}
4038

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,9 @@ test(`should return "Invalid angle" when angle < 1 `, () => {
4444

4545
test(`should return "Invalid angle" when angle > 360 `, () => {
4646
expect(getAngleType(361)).toEqual("Invalid angle");
47+
});
48+
49+
// Largest valid angle(boundary case)
50+
test(`should return "Straight angle" when angle is the maximum valid value (360)`, () => {
51+
expect(getAngleType(360)).toEqual("Straight angle");
4752
});

0 commit comments

Comments
 (0)