Skip to content

Commit 5264a59

Browse files
committed
updated mandatory-interpret 2-time.js with additional comments on output oddities
1 parent f16fcab commit 5264a59

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

Sprint-1/3-mandatory-interpret/2-time-format.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,17 @@ console.log(result);
4444
// I changed the value to;
4545
// 1200 returned 0:20:00
4646
// 92383.7 returned 25:39:43.69999999999709
47+
// Milliseconds appeared in the output because they were part of the
48+
// input and were not explicitly removed, even though they were not required
49+
// and it does make the output not what is expected.
50+
// In this cases there was no validation to stop this from occurring.
51+
4752
// -8784 returned -2:-26:-24
48-
// it worked with all numbers including decimals and negative numbers.
53+
// Negative numbers passed the test.
54+
// In reality there should not be negative time in the movieLength and
55+
// it should throw an error. In this cases there was no validation to stop
56+
// this from occurring.
57+
58+
// It worked with all numbers including decimals and negative numbers.
59+
60+

0 commit comments

Comments
 (0)