Sprint 3 implement and rewrite tests

Author: arunkumarakilan

Sprint-3/1-implement-and-rewrite-tests/README.md

@@ -5,11 +5,10 @@ to choose test values that thoroughly test a function.
 
 ## 1 Implement solutions
 
-
 Here is a recommended order:
 
 1. `1-get-angle-type.js`In the `implement` directory you've got a number of functions you'll need to implement.
-For each function, you also have a number of different cases you'll need to check for your function.
+   For each function, you also have a number of different cases you'll need to check for your function.
 
 Write your assertions and build up your program case by case. Don't rush to a solution. The point of these assignments is to learn how to write assertions and build up a program step by step.
 

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -15,30 +15,19 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-  if(angle > 0 && angle <90)
-  {
-    return 'Acute angle';
+  if (angle > 0 && angle < 90) {
+    return "Acute angle";
+  } else if (angle === 90) {
+    return "Right angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else {
+    return "Invalid angle";
   }
-  else if(angle === 90){
-    return 'Right angle'
-  }
-  else if(angle > 90 && angle < 180)
-    {
-    return  "Obtuse angle" 
-  }
-  else if(angle === 180)
-  {
-    return "Straight angle" ;
-  }
-  else if( angle > 180 && angle < 360)
-  {
-    return "Reflex angle" ;
-  }
-  else 
-
-    {
-      return "Invalid angle"
-    }
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -50,7 +39,7 @@ module.exports = getAngleType;
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
+    `Expected ${actualOutput} to equal ${targetOutput}`,
   );
 }
 
@@ -60,9 +49,9 @@ let invalid = getAngleType(0);
 assertEquals(invalid, "Invalid angle");
 let acute = getAngleType(1);
 assertEquals(acute, "Acute angle");
- acute = getAngleType(89);
+acute = getAngleType(89);
 assertEquals(acute, "Acute angle");
-let right= getAngleType(90);
+let right = getAngleType(90);
 assertEquals(right, "Right angle");
 let obtuse = getAngleType(91);
 assertEquals(obtuse, "Obtuse angle");
@@ -74,6 +63,5 @@ let reflex = getAngleType(181);
 assertEquals(reflex, "Reflex angle");
 reflex = getAngleType(359);
 assertEquals(reflex, "Reflex angle");
- invalid = getAngleType(400);
+invalid = getAngleType(400);
 assertEquals(invalid, "Invalid angle");
-

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,16 +11,11 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if (denominator === 0){
+  if (denominator === 0) {
     return false;
-  }
-  else if (numerator < denominator)
-  {
+  } else if (numerator < denominator) {
     return true;
-
-  }
-  else
-  {
+  } else {
     return false;
   }
 }
@@ -33,7 +28,7 @@ module.exports = isProperFraction;
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
+    `Expected ${actualOutput} to equal ${targetOutput}`,
   );
 }
 
@@ -48,4 +43,4 @@ assertEquals(isProperFraction(0, 5), true);
 assertEquals(isProperFraction(1, 0), false);
 assertEquals(isProperFraction(-3, 2), true);
 assertEquals(isProperFraction(2, -5), false);
-assertEquals(isProperFraction(-2, -3), false);
+assertEquals(isProperFraction(-2, -3), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,31 +22,38 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  if(typeof card !== "string" || card.length<2)
-  {
+  if (typeof card !== "string" || card.length < 2) {
     throw new Error("Invalid card");
   }
   const suit = card.slice(-1);
   const rank = card.slice(0, -1);
 
   const validSuits = ["♠", "♥", "♦", "♣"];
-  const validRanks = ["A","2","3","4","5","6","7","8","9","10","J","Q","K"];
+  const validRanks = [
+    "A",
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+    "10",
+    "J",
+    "Q",
+    "K",
+  ];
 
-   if(!validSuits.includes(suit) || !validRanks.includes(rank))
-  {
+  if (!validSuits.includes(suit) || !validRanks.includes(rank)) {
     throw new Error("Invalid card");
-  }
-  else if (rank == "A")
-  {
+  } else if (rank == "A") {
     return 11;
+  } else if (["J", "Q", "K"].includes(rank)) {
+    return 10;
+  } else {
+    return Number(rank);
   }
-  else if (["J","Q","K"].includes(rank))
-{
-  return 10
-}
-else {
-  return Number(rank);
-}
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -57,15 +64,15 @@ module.exports = getCardValue;
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
-    `Expected ${actualOutput} to equal ${targetOutput}`
+    `Expected ${actualOutput} to equal ${targetOutput}`,
   );
 }
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
 assertEquals(getCardValue("9♠"), 9);
 assertEquals(getCardValue("A♠"), 11);
-assertEquals(getCardValue("K♦"), 10); 
+assertEquals(getCardValue("K♦"), 10);
 assertEquals(getCardValue("10♥"), 10);
 
 // Handling invalid cards
@@ -75,29 +82,26 @@ try {
 } catch (e) {}
 try {
   getCardValue("A?");
-console.error("Error was not thrown for invalid card");
+  console.error("Error was not thrown for invalid card");
 } catch (e) {}
 try {
   getCardValue("A");
 
-  
   console.error("Error was not thrown for invalid card");
 } catch (e) {}
 try {
   getCardValue("10");
 
-  
   console.error("Error was not thrown for invalid card");
 } catch (e) {}
 
 // What other invalid card cases can you think of?
 //try {
-  //getCardValue("AA");
+//getCardValue("AA");
 //console.error("Error was not thrown for invalid card");
 //} catch (e) {}
 //try {
-  //getCardValue("1♠");
+//getCardValue("1♠");
 
-  
-  //console.error("Error was not thrown for invalid card");
-//} catch (e) {}
+//console.error("Error was not thrown for invalid card");
+//} catch (e) {}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -16,21 +16,20 @@ test(`should return "Right angle" when (angle = 90)`, () => {
   // Test various acute angles, including boundary cases
   expect(getAngleType(90)).toEqual("Right angle");
 });
-test(`should return"Obtuse angle" when (90 < angle< 180)`, ()=>{
+test(`should return"Obtuse angle" when (90 < angle< 180)`, () => {
   expect(getAngleType(91)).toEqual("Obtuse angle");
   expect(getAngleType(179)).toEqual("Obtuse angle");
 });
-test(`should return "Straight angle" when ( angle = 180)`,()=>{
+test(`should return "Straight angle" when ( angle = 180)`, () => {
   expect(getAngleType(180)).toEqual("Straight angle");
 });
-test(`should return "Reflex angle" when (180 < angle <360)`, ()=>{
+test(`should return "Reflex angle" when (180 < angle <360)`, () => {
   expect(getAngleType(181)).toEqual("Reflex angle");
   expect(getAngleType(359)).toEqual("Reflex angle");
-
 });
-test(`should return "invalid angle when angles outside the valid range`, ()=>{
-  expect(getAngleType(0)).toEqual("Invalid angle")
-})
+test(`should return "invalid angle when angles outside the valid range`, () => {
+  expect(getAngleType(0)).toEqual("Invalid angle");
+});
 
 // Case 2: Right angle
 // Case 3: Obtuse angles

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,24 +8,24 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
-test(`Should return true when numerator is zero`, ()=>{
+test(`Should return true when numerator is zero`, () => {
   expect(isProperFraction(0, 5)).toEqual(true);
 });
-test(`should return true when denominator is greater than numerator`, () =>{
-expect(isProperFraction(1, 2)).toEqual(true);
+test(`should return true when denominator is greater than numerator`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
 });
-test(`should return false when numerator is greater than denominator`, ()=> {
+test(`should return false when numerator is greater than denominator`, () => {
   expect(isProperFraction(5, 4)).toEqual(false);
 });
-test(`should return false when numerator is equals to denominator`, ()=>{
-expect(isProperFraction(3, 3)).toEqual(false);
+test(`should return false when numerator is equals to denominator`, () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
 });
-test(`should return true when denominator is greater than negative numerator`, ()=>{
+test(`should return true when denominator is greater than negative numerator`, () => {
   expect(isProperFraction(-3, 2)).toEqual(true);
 });
-test(`should return false when numerator is greater than denominator`, ()=> {
+test(`should return false when numerator is greater than denominator`, () => {
   expect(isProperFraction(2, -5)).toEqual(false);
 });
-test(`should return false when negative numerator is greater than negative denominator`, ()=> {
+test(`should return false when negative numerator is greater than negative denominator`, () => {
   expect(isProperFraction(-2, -3)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,26 +8,26 @@ const getCardValue = require("../implement/3-get-card-value");
 test(`Should return 11 when given an ace card`, () => {
   expect(getCardValue("A♠")).toEqual(11);
 });
-test(`should return 9 when given a 9♠ card`,()=>{
+test(`should return 9 when given a 9♠ card`, () => {
   expect(getCardValue("9♠")).toEqual(9);
 });
-test (`should return 10 when given a face card K♦`, ()=>{
+test(`should return 10 when given a face card K♦`, () => {
   expect(getCardValue("K♦")).toEqual(10);
 });
-test(`should return 10 when given a 10`, ()=>{
+test(`should return 10 when given a 10`, () => {
   expect(getCardValue("10♥")).toEqual(10);
 });
-test(`should throw error for invalid Ranks`, ()=>{
-  expect(()=> getCardValue("11♠")).toThrow();
+test(`should throw error for invalid Ranks`, () => {
+  expect(() => getCardValue("11♠")).toThrow();
 });
-test(`should throw error for invalid Suits`, ()=>{
-  expect(()=> getCardValue("A?")).toThrow();
+test(`should throw error for invalid Suits`, () => {
+  expect(() => getCardValue("A?")).toThrow();
 });
-test(`should throw error for missing Suits`,()=>{
-  expect(()=> getCardValue("A")).toThrow();
+test(`should throw error for missing Suits`, () => {
+  expect(() => getCardValue("A")).toThrow();
 });
-test(`should throw error for non String input`, ()=>{
-  expect(()=> getCardValue("10")).toThrow();
+test(`should throw error for non String input`, () => {
+  expect(() => getCardValue("10")).toThrow();
 });
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
@@ -37,4 +37,3 @@ test(`should throw error for non String input`, ()=>{
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-