Skip to content

Commit 4eea1fd

Browse files
committed
Improved tasks
1 parent 7e1ce07 commit 4eea1fd

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const getAngleType = require("../implement/1-get-angle-type");
66
// including boundary and invalid cases.
77

88
// Case 1: Acute angles
9-
test("should return 'Acute angle' when (0 < angle < 90)", () => {
9+
test("should return 'Acute angle' when angle ∈ ]0, 90[", () => {
1010
expect(getAngleType(1)).toEqual("Acute angle");
1111
expect(getAngleType(45)).toEqual("Acute angle");
1212
expect(getAngleType(89)).toEqual("Acute angle");
@@ -18,7 +18,7 @@ test("should return 'Right angle' when angle is 90", () => {
1818
});
1919

2020
// Case 3: Obtuse angles
21-
test("should return 'Obtuse angle' when (90 < angle < 180)", () => {
21+
test("should return 'Obtuse angle' when angle ∈ ]90, 180[", () => {
2222
expect(getAngleType(91)).toEqual("Obtuse angle");
2323
expect(getAngleType(135)).toEqual("Obtuse angle");
2424
expect(getAngleType(179)).toEqual("Obtuse angle");
@@ -30,16 +30,15 @@ test("should return 'Straight angle' when angle is 180", () => {
3030
});
3131

3232
// Case 5: Reflex angles
33-
test("should return 'Reflex angle' when (180 < angle < 360)", () => {
33+
test("should return 'Reflex angle' when angle ∈ ]180, 360[", () => {
3434
expect(getAngleType(181)).toEqual("Reflex angle");
3535
expect(getAngleType(270)).toEqual("Reflex angle");
3636
expect(getAngleType(359)).toEqual("Reflex angle");
3737
});
3838

3939
// Case 6: Invalid angles
40-
test("should return 'Invalid angle' when angle is < 0, >= 360, or not a number", () => {
40+
test("should return 'Invalid angle' when angle is < 0 or >= 360", () => {
4141
expect(getAngleType(-1)).toEqual("Invalid angle");
4242
expect(getAngleType(360)).toEqual("Invalid angle");
4343
expect(getAngleType(400)).toEqual("Invalid angle");
44-
expect(getAngleType("invalid")).toEqual("Invalid angle");
4544
});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
44

55
// TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
66

7-
// Case 1: Proper fractions (numerator < denominator)
8-
test("should return true when numerator is less than denominator", () => {
7+
// Case 1: Proper fractions (|numerator| < |denominator|)
8+
test("should return true when |numerator| < |denominator|", () => {
99
expect(isProperFraction(1, 2)).toEqual(true);
1010
expect(isProperFraction(3, 4)).toEqual(true);
1111
expect(isProperFraction(0, 5)).toEqual(true);
@@ -21,8 +21,8 @@ test("should return false when |numerator| >= |denominator|", () => {
2121
expect(isProperFraction(-5, -5)).toEqual(false);
2222
});
2323

24-
// Case 3: Negative numbers
25-
test("should handle negative numbers", () => {
24+
// Case 3: Proper fractions with negative values (|numerator| < |denominator|)
25+
test("should return true when |numerator| < |denominator| with negative values", () => {
2626
expect(isProperFraction(-1, 2)).toEqual(true);
2727
expect(isProperFraction(1, -2)).toEqual(true);
2828
expect(isProperFraction(-3, -4)).toEqual(true);

0 commit comments

Comments
 (0)