fixing errors using mentor feedback

Author: Abduhasen

Sprint-2/3-mandatory-implement/1-bmi.js

@@ -19,6 +19,6 @@ function calculateBMI(weight, height) {
   // return the BMI of someone based off their weight and height
   const squaringHeight = height * height;
   const resultBMI = weight / squaringHeight;
-  return resultBMI.toFixed(1);
+  return Number(resultBMI.toFixed(1));
 }
 console.log(calculateBMI(weight, height));

Sprint-2/4-mandatory-interpret/time-format.js

@@ -25,10 +25,10 @@ console.log(formatTimeDisplay(61));
 // =============> write your answer here :0
 
 // c) What is the return value of pad is called for the first time?
-// =============> write your answer here:00
+// =============> write your answer here:"00"
 
 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here: pad(00):pad(01):pad(01) because it will take the value of totalHours,remainingMinutes,remainingSeconds.
 
 // e) What is the return value assigned to num when pad is called for the last time in this program?  Explain your answer
-// =============> write your answer here: the return value will be 00:01:01 because it is the final argument passed to pad() in the return statement.
+// =============> write your answer here: the return value will be "01" because 61 seconds has 1 second left after converting to minutes.

Sprint-2/5-stretch-extend/format-time.js

@@ -4,43 +4,49 @@
 
 function formatAs12HourClock(time) {
   const hours = Number(time.slice(0, 2));
-  const minutes = time.slice(3, 5);
+  const minutes = time.slice(-2);
   if (hours > 12) {
-    return `${hours - 12}:${minutes} pm`;
+    return `${String(hours - 12).padStart(2, "0")}:${minutes}pm`;
   } else if (hours == 12) {
-    return `12:${minutes} pm`;
+    return `12:${minutes}pm`;
   } else if (hours === 0) {
-    return `12:${minutes} am`;
+    return `12:${minutes}am`;
   }
-  return `${String(hours).padStart(2, "0")}:${minutes} am`;
+  return `${String(hours).padStart(2, "0")}:${minutes}am`;
 }
 let currentOutput = formatAs12HourClock("00:01");
-let targetOutput = "12:01 am";
+let targetOutput = "12:01am";
 console.assert(
   currentOutput === targetOutput,
   `current output: ${currentOutput}, target output: ${targetOutput}`
 );
 
 const currentOutput2 = formatAs12HourClock("11:59");
-const targetOutput2 = "11:59 am";
+const targetOutput2 = "11:59am";
 console.assert(
   currentOutput2 === targetOutput2,
   `current output: ${currentOutput2}, target output: ${targetOutput2}`
 );
 const currentOutput3 = formatAs12HourClock("12:00");
-const targetOutput3 = "12:00 pm";
+const targetOutput3 = "12:00pm";
 console.assert(
   currentOutput3 === targetOutput3,
   `current output: ${currentOutput3}, target output: ${targetOutput3}`
 );
 currentOutput = formatAs12HourClock("00:00");
-targetOutput = "12:00 am";
+targetOutput = "12:00am";
 console.assert(
   currentOutput === targetOutput,
   `current output: ${currentOutput}, target output: ${targetOutput}`
 );
 currentOutput = formatAs12HourClock("04:12");
-targetOutput = "04:12 am";
+targetOutput = "04:12am";
+console.assert(
+  currentOutput === targetOutput,
+  `current output: ${currentOutput}, target output: ${targetOutput}`
+);
+currentOutput = formatAs12HourClock("16:12");
+targetOutput = "04:12pm";
 console.assert(
   currentOutput === targetOutput,
   `current output: ${currentOutput}, target output: ${targetOutput}`