Refine proper fraction comments and clarify invalid angle test description

Author: Richiealx

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -1,70 +1,61 @@
-// Implement a function isProperFraction.
-// When given two numbers, a numerator and a denominator, it should return true
-// if the given numbers form a proper fraction, and false otherwise.
+// Implement a function isProperFraction,
+// when given two numbers, a numerator and a denominator, it should return true if
+// the given numbers form a proper fraction, and false otherwise.
 
 // Assumption: The parameters are valid numbers (not NaN or Infinity).
 
-// Definition:
-// A proper fraction is a fraction where:
-// - the denominator is not zero
-// - both numbers are non-negative
-// - the numerator is smaller than the denominator
+// Note: If you are unfamiliar with proper fractions, please look up its mathematical definition.
 
 // Acceptance criteria:
-// After implementing the function, write tests to cover all cases
-// and run the code to ensure all tests pass.
+// After you have implemented the function, write tests to cover all the cases, and
+// execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  // A fraction with denominator 0 is invalid
+  // A fraction with denominator 0 is invalid.
   if (denominator === 0) {
     return false;
   }
 
-  // Negative values are not allowed
+  // For this implementation, proper fractions are positive fractions
+  // where the numerator is smaller than the denominator.
   if (numerator < 0 || denominator < 0) {
     return false;
   }
 
-  // A proper fraction must have numerator smaller than denominator
   if (numerator < denominator) {
     return true;
   }
 
-  // All other cases are not proper fractions
   return false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = isProperFraction;
 
-// Helper function for simple assertions in this file
+// Here's our helper again
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
     `Expected ${actualOutput} to equal ${targetOutput}`
   );
 }
 
-// Tests to cover different combinations of numerators and denominators
+// TODO: Write tests to cover all cases.
+// What combinations of numerators and denominators should you test?
 
 // Example: 1/2 is a proper fraction
 assertEquals(isProperFraction(1, 2), true);
 
-// Proper fractions (numerator smaller than denominator)
+// Proper fractions
 assertEquals(isProperFraction(3, 5), true);
-assertEquals(isProperFraction(2, 7), true);
+assertEquals(isProperFraction(0, 5), true);
 
-// Improper fractions (numerator greater than or equal to denominator)
+// Improper fractions
 assertEquals(isProperFraction(5, 5), false);
 assertEquals(isProperFraction(7, 3), false);
 
-// Negative numbers should return false
-assertEquals(isProperFraction(-2, 7), false);
-assertEquals(isProperFraction(2, -7), false);
-
-// Zero numerator is allowed if denominator is positive
-assertEquals(isProperFraction(0, 5), true);
-
-// Invalid fraction (denominator is zero)
+// Invalid fractions
 assertEquals(isProperFraction(2, 0), false);
+assertEquals(isProperFraction(-1, 2), false);
+assertEquals(isProperFraction(1, -2), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -6,7 +6,7 @@ const getAngleType = require("../implement/1-get-angle-type");
 // including boundary and invalid cases.
 
 // Case 1: Acute angles
-test(`should return "Acute angle" when (0 < angle < 90)`, () => {
+test(`should return "Acute angle" when 0 < angle < 90`, () => {
   // Test various acute angles, including boundary cases
   expect(getAngleType(1)).toEqual("Acute angle");
   expect(getAngleType(45)).toEqual("Acute angle");
@@ -19,7 +19,7 @@ test(`should return "Right angle" when angle is exactly 90`, () => {
 });
 
 // Case 3: Obtuse angles
-test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+test(`should return "Obtuse angle" when 90 < angle < 180`, () => {
   expect(getAngleType(91)).toEqual("Obtuse angle");
   expect(getAngleType(120)).toEqual("Obtuse angle");
   expect(getAngleType(179)).toEqual("Obtuse angle");
@@ -31,14 +31,14 @@ test(`should return "Straight angle" when angle is exactly 180`, () => {
 });
 
 // Case 5: Reflex angles
-test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+test(`should return "Reflex angle" when 180 < angle < 360`, () => {
   expect(getAngleType(181)).toEqual("Reflex angle");
   expect(getAngleType(270)).toEqual("Reflex angle");
   expect(getAngleType(359)).toEqual("Reflex angle");
 });
 
 // Case 6: Invalid angles
-test(`should return "Invalid angle" for angles outside valid range`, () => {
+test(`should return "Invalid angle" for angles less than or equal to 0, or greater than or equal to 360`, () => {
   expect(getAngleType(0)).toEqual("Invalid angle");
   expect(getAngleType(360)).toEqual("Invalid angle");
   expect(getAngleType(-10)).toEqual("Invalid angle");