Skip to content

Commit 2cd0d86

Browse files
committed
still need -numbers
1 parent f308251 commit 2cd0d86

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
// execute the code to ensure all tests pass.
1212

1313
function isProperFraction(numerator, denominator) {
14-
return (numerator >= denominator ) ? false : true
14+
15+
return (numerator < denominator )
1516
}
1617

1718
// The line below allows us to load the isProperFraction function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,6 @@ test(`should return false when the (numerator > denominator)`,()=>{
2121
test(`Should return a true when the (numerator < denominator)`,()=>{
2222
expect(isProperFraction(1,2)).toEqual(true)
2323
expect(isProperFraction(6,8)).toEqual(true)
24-
expect(isProperFraction(-1,2)).toEqual(true)
24+
expect(isProperFraction(-3,2)).toEqual(true)
2525
});
26+

0 commit comments

Comments
 (0)