fixing code based on mentor feedback

Author: Abduhasen

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,18 +22,35 @@
 // execute the code to ensure all tests pass.
 function getCardValue(card) {
   // TODO: Implement this function
-  if (typeof card !== "string") {
+  if (!card || typeof card !== "string") {
     throw new Error("Invalid card");
   }
+  //
   const validSuits = ["♠", "♥", "♦", "♣"];
-  const suit = card.slice(-1);
-  const rank = card.slice(0, -1);
+  const suit = card.slice(-1); //takes the last character of the string.
+  const rank = card.slice(0, -1); //takes everything except the last character.
+
   if (!validSuits.includes(suit)) {
-    throw new Error("Invalid card");
-  } else if (rank === "A") return 11;
-  else if (["J", "Q", "K"].includes(rank)) return 10;
-  const number = Number(rank);
-  if (number >= 2 && number <= 10) return number;
+    throw new Error("Invalid card"); // This if statement checks the suit is valid with the Array of suit we assigned
+  }
+  // Based on the question i get form mentor i changed the function if statement for better experience of the code.
+  const cardValues = {
+    A: 11,
+    J: 10,
+    Q: 10,
+    K: 10,
+    2: 2,
+    3: 3,
+    4: 4,
+    5: 5,
+    6: 6,
+    7: 7,
+    8: 8,
+    9: 9,
+    10: 10,
+  }; // This is java script object that act as like lookup table for the valid card value input.
+
+  if (cardValues[rank] !== undefined) return cardValues[rank];
   throw new Error("Invalid card");
 }
 

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -42,4 +42,5 @@ test(`should return "Invalid angles" when (angle >= 360 or angle<= 0 )`, () => {
   expect(getAngleType(0)).toBe("Invalid angle");
   expect(getAngleType(-45)).toBe("Invalid angle");
   expect(getAngleType(370)).toBe("Invalid angle");
+  expect(getAngleType(360)).toBe("Invalid angle");
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -5,16 +5,23 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 // Special case: numerator is zero
 test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
-  expect(isProperFraction(0, 1)).toEqual(true);
+  expect(isProperFraction(-11, 0)).toEqual(false);
+  expect(isProperFraction(0, 0)).toEqual(false);
+  expect(isProperFraction(7, 0)).toEqual(false);
+});
+// It should return false when the numerator > the denominator
+test("should return true when numerator is 0", () => {
   expect(isProperFraction(0, -1)).toEqual(true);
-  expect(isProperFraction(18, 1)).toEqual(false);
-  expect(isProperFraction(7, 3)).toEqual(false);
-  expect(isProperFraction(1, -2)).toEqual(true);
-  expect(isProperFraction(-15, -9)).toEqual(false);
-  expect(isProperFraction(-2, -6)).toEqual(true);
-  expect(isProperFraction(-137, -71)).toEqual(false);
-  expect(isProperFraction(-100, -189)).toEqual(true);
+  expect(isProperFraction(0, 3)).toEqual(true);
+  expect(isProperFraction(0, -2)).toEqual(true);
+});
+test("should return true when numerator > denominator", () => {
+  expect(isProperFraction(-12, -19)).toEqual(true);
+  expect(isProperFraction(0, 6)).toEqual(true);
+  expect(isProperFraction(17, -71)).toEqual(true);
+});
+test("should return false when numerator < denominator", () => {
+  expect(isProperFraction(-180, -109)).toEqual(false);
   expect(isProperFraction(27, 5)).toEqual(false);
   expect(isProperFraction(-29, 17)).toEqual(false);
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -27,6 +27,9 @@ test(`Should throw "Invalid card" for invalid cards`, () => {
   expect(() => getCardValue("B♠")).toThrow("Invalid card");
   expect(() => getCardValue("A$")).toThrow("Invalid card");
   expect(() => getCardValue("10X")).toThrow("Invalid card");
+  expect(() => getCardValue("0x02♠")).toThrow("Invalid card");
+  expect(() => getCardValue("2.1♠")).toThrow("Invalid card");
+  expect(() => getCardValue("0002♠")).toThrow("Invalid card");
 });
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)