Skip to content

Commit 16441f2

Browse files
committed
Update tests and logic so 0 is classified as an invalid angle
1 parent 697147f commit 16441f2

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// execute the code to ensure all tests pass.
1616

1717
function getAngleType(angle) {
18-
if (angle >= 0 && angle < 90) {
18+
if (angle > 0 && angle < 90) {
1919
return "Acute angle";
2020
} else if (angle === 90) {
2121
return "Right angle";
@@ -28,7 +28,6 @@ function getAngleType(angle) {
2828
}
2929
return "Invalid angle";
3030
}
31-
3231
// The line below allows us to load the getAngleType function into tests in other files.
3332
// This will be useful in the "rewrite tests with jest" step.
3433
module.exports = getAngleType;

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ const getAngleType = require("../implement/1-get-angle-type");
66
// including boundary and invalid cases.
77

88
// Case 1: Acute angles
9-
test("should return 'Acute angle' when angle ∈ [0, 90[", () => {
10-
expect(getAngleType(0)).toEqual("Acute angle");
9+
test("should return 'Acute angle' when angle ∈ ]0, 90[", () => {
1110
expect(getAngleType(1)).toEqual("Acute angle");
1211
expect(getAngleType(45)).toEqual("Acute angle");
1312
expect(getAngleType(89)).toEqual("Acute angle");
@@ -20,7 +19,7 @@ test("should return 'Right angle' when angle is 90", () => {
2019

2120
// Case 3: Obtuse angles
2221
test("should return 'Obtuse angle' when angle ∈ ]90, 180[", () => {
23-
expect(getAngleType(91)).toEqual("Obtuse angle");
22+
expect(getAngleType(91)).toEqual("Obtuse angle");
2423
expect(getAngleType(135)).toEqual("Obtuse angle");
2524
expect(getAngleType(179)).toEqual("Obtuse angle");
2625
});
@@ -40,6 +39,7 @@ test("should return 'Reflex angle' when angle ∈ ]180, 360[", () => {
4039
// Case 6: Invalid angles
4140
test("should return 'Invalid angle' when angle is < 0 or >= 360", () => {
4241
expect(getAngleType(-1)).toEqual("Invalid angle");
42+
expect(getAngleType(0)).toEqual("Invalid angle");
4343
expect(getAngleType(360)).toEqual("Invalid angle");
4444
expect(getAngleType(400)).toEqual("Invalid angle");
4545
});

0 commit comments

Comments
 (0)