Skip to content

Commit 10e3a62

Browse files
committed
Refactor code examples for clarity and correctness in mandatory errors
1 parent 9c6bef1 commit 10e3a62

File tree

5 files changed

+19
-2
lines changed

5 files changed

+19
-2
lines changed

Sprint-1/2-mandatory-errors/0.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
This is just an instruction for the first activity - but it is just for human consumption
2-
We don't want the computer to run these 2 lines - how can we solve this problem?
2+
We don't want the computer to run these 2 lines - how can we solve this problem?
3+
4+
//This is just an instruction for the first activity - but it is just for human consumption
5+
//We don't want the computer to run these 2 lines - how can we solve this problem?

Sprint-1/2-mandatory-errors/1.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,6 @@
22

33
const age = 33;
44
age = age + 1;
5+
6+
let age = 33;
7+
age = age + 1;

Sprint-1/2-mandatory-errors/2.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33

44
console.log(`I was born in ${cityOfBirth}`);
55
const cityOfBirth = "Bolton";
6+
console.log(`I was born in ${cityOfBirth}`);

Sprint-1/2-mandatory-errors/3.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,10 @@ const last4Digits = cardNumber.slice(-4);
77
// Then run the code and see what error it gives.
88
// Consider: Why does it give this error? Is this what I predicted? If not, what's different?
99
// Then try updating the expression last4Digits is assigned to, in order to get the correct value
10+
11+
// Prediction: The code won't work because cardNumber is a number, and the slice method is a string method.
12+
// When we try to call slice on a number, it will throw a TypeError because numbers do not have the slice method.
13+
// To fix this, we can convert cardNumber to a string before calling slice on it.
14+
15+
const last4Digits = String(cardNumber).slice(-4);
16+

Sprint-1/2-mandatory-errors/4.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
const 12HourClockTime = "20:53";
2-
const 24hourClockTime = "08:53";
2+
const 24hourClockTime = "08:53";
3+
4+
const twelveHourClockTime = "20:53";
5+
const twentyFourHourClockTime = "08:53";

0 commit comments

Comments
 (0)