From 90bc52833cb6424701a067b9b2abf338c4964b2e Mon Sep 17 00:00:00 2001 From: MacDonald91 Date: Fri, 10 Apr 2026 21:14:09 +0100 Subject: [PATCH 1/2] Debugging task - fixed bugs in library app (render, add, delete, read toggle) --- debugging/book-library/index.html | 49 +++++++++---------- debugging/book-library/script.js | 81 ++++++++++++++++--------------- 2 files changed, 67 insertions(+), 63 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..d5c19031 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,11 @@ - - + Library App + + + + @@ -14,6 +13,7 @@ rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" /> + @@ -23,28 +23,32 @@

Library

Add books to your virtual library

+ +
- + + + Library name="pages" required /> + - + +
+ @@ -81,16 +85,11 @@

Library

- - - - - - - +
+ - + \ No newline at end of file diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..5675edfa 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,48 +1,52 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + if (myLibrary.length === 0) { + let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); let book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", true ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); + myLibrary.push(book1, book2); } } +// FORM INPUTS const title = document.getElementById("title"); const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function +// ADD BOOK function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" + title.value === "" || + author.value === "" || + pages.value === "" ) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; } + + let book = new Book( + title.value, + author.value, // ✅ FIXED (was using title twice) + pages.value, + check.checked // ✅ FIXED (correct checkbox value) + ); + + myLibrary.push(book); // ✅ FIXED (was "library") + render(); } +// BOOK OBJECT function Book(title, author, pages, check) { this.title = title; this.author = author; @@ -50,37 +54,35 @@ function Book(title, author, pages, check) { this.check = check; } +// RENDER TABLE function render() { let table = document.getElementById("display"); + + // CLEAR OLD ROWS let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { // ✅ FIXED SYNTAX table.deleteRow(n); } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { + + // ADD ROWS + for (let i = 0; i < myLibrary.length; i++) { let row = table.insertRow(1); + let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); + titleCell.innerHTML = myLibrary[i].title; authorCell.innerHTML = myLibrary[i].author; pagesCell.innerHTML = myLibrary[i].pages; - //add and wait for action for read/unread button + // READ BUTTON let changeBut = document.createElement("button"); - changeBut.id = i; changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } + + let readStatus = myLibrary[i].check ? "Yes" : "No"; // ✅ FIXED changeBut.innerText = readStatus; changeBut.addEventListener("click", function () { @@ -88,16 +90,19 @@ function render() { render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); + wasReadCell.appendChild(changeBut); + + // DELETE BUTTON + let delBut = document.createElement("button"); // ✅ FIXED NAME delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + + delBut.addEventListener("click", function () { // ✅ FIXED EVENT + alert(`You've deleted: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); }); + + deleteCell.appendChild(delBut); } -} +} \ No newline at end of file From eaa6e32f6416f707b697ca1b03d510d620ffe02a Mon Sep 17 00:00:00 2001 From: MacDonald91 Date: Mon, 20 Apr 2026 21:26:44 +0100 Subject: [PATCH 2/2] fixed code and refactored --- debugging/book-library/script.js | 125 +++++++++++++++---------------- debugging/book-library/style.css | 10 +-- 2 files changed, 64 insertions(+), 71 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 5675edfa..ffa780e9 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,108 +1,101 @@ let myLibrary = []; -window.addEventListener("load", function () { +window.addEventListener("load", () => { populateStorage(); render(); }); +// ------------------ +// DATA SETUP +// ------------------ function populateStorage() { if (myLibrary.length === 0) { - let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true + myLibrary.push( + new Book("Robinson Crusoe", "Daniel Defoe", 252, true), + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) ); - myLibrary.push(book1, book2); } } -// FORM INPUTS -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +function Book(title, author, pages, alreadyRead) { + this.title = title; + this.author = author; + this.pages = pages; + this.alreadyRead = alreadyRead; +} +// ------------------ +// DOM ELEMENTS +// ------------------ +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); + +// ------------------ // ADD BOOK +// ------------------ function submit() { - if ( - title.value === "" || - author.value === "" || - pages.value === "" - ) { + if (!titleInput.value || !authorInput.value || !pagesInput.value) { alert("Please fill all fields!"); return; } - let book = new Book( - title.value, - author.value, // ✅ FIXED (was using title twice) - pages.value, - check.checked // ✅ FIXED (correct checkbox value) + const book = new Book( + titleInput.value, + authorInput.value, + pagesInput.value, + checkInput.checked ); - myLibrary.push(book); // ✅ FIXED (was "library") + myLibrary.push(book); render(); } -// BOOK OBJECT -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; -} - -// RENDER TABLE +// ------------------ +// RENDER +// ------------------ function render() { - let table = document.getElementById("display"); + const table = document.getElementById("display"); - // CLEAR OLD ROWS - let rowsNumber = table.rows.length; - for (let n = rowsNumber - 1; n > 0; n--) { // ✅ FIXED SYNTAX - table.deleteRow(n); + // clear old rows + while (table.rows.length > 1) { + table.deleteRow(1); } - // ADD ROWS - for (let i = 0; i < myLibrary.length; i++) { - let row = table.insertRow(1); + myLibrary.forEach((book, index) => { + const row = table.insertRow(); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); + row.insertCell(0).textContent = book.title; + row.insertCell(1).textContent = book.author; + row.insertCell(2).textContent = book.pages; - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + // READ TOGGLE + const readCell = row.insertCell(3); + const toggleBtn = document.createElement("button"); - // READ BUTTON - let changeBut = document.createElement("button"); - changeBut.className = "btn btn-success"; + toggleBtn.className = "btn btn-success"; + toggleBtn.textContent = book.alreadyRead ? "Yes" : "No"; - let readStatus = myLibrary[i].check ? "Yes" : "No"; // ✅ FIXED - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + toggleBtn.addEventListener("click", () => { + book.alreadyRead = !book.alreadyRead; render(); }); - wasReadCell.appendChild(changeBut); + readCell.appendChild(toggleBtn); // DELETE BUTTON - let delBut = document.createElement("button"); // ✅ FIXED NAME - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; + const deleteCell = row.insertCell(4); + const deleteBtn = document.createElement("button"); + + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; - delBut.addEventListener("click", function () { // ✅ FIXED EVENT - alert(`You've deleted: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + deleteBtn.addEventListener("click", () => { + myLibrary.splice(index, 1); render(); }); - deleteCell.appendChild(delBut); - } + deleteCell.appendChild(deleteBtn); + }); } \ No newline at end of file diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..624a35c9 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -1,19 +1,19 @@ .form-group { width: 400px; - height: 300px; - align-self: left; padding-left: 20px; } -.btn { +/* Only target your specific button */ +#demo .btn { display: block; + margin-top: 10px; } .form-check-label { padding-left: 20px; - margin: 5px 0px 5px 0px; + margin: 5px 0; } button.btn-info { margin: 20px; -} +} \ No newline at end of file