Skip to content

Commit cf086ff

Browse files
fix: More deprecations and updates for PHP 8.4
1 parent 1d70c23 commit cf086ff

File tree

6 files changed

+7
-11
lines changed

6 files changed

+7
-11
lines changed

src/Embeddings/JinaEmbeddingFunction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
class JinaEmbeddingFunction implements EmbeddingFunction
1414
{
15-
private Client $client;
15+
private readonly Client $client;
1616

1717
public function __construct(
1818
public readonly string $apiKey,

src/Embeddings/OllamaEmbeddingFunction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
class OllamaEmbeddingFunction implements EmbeddingFunction
1111
{
12-
private Client $client;
12+
private readonly Client $client;
1313

1414
public function __construct(
1515
public readonly string $baseUrl = 'http://localhost:11434',

src/Embeddings/OpenAIEmbeddingFunction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class OpenAIEmbeddingFunction implements EmbeddingFunction
1212
{
13-
private Client $client;
13+
private readonly Client $client;
1414

1515
public function __construct(
1616
public readonly string $apiKey,

src/Generated/ChromaApiClient.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,7 @@ public function listCollections(string $database, string $tenant): array
154154

155155
$result = json_decode($response->getBody()->getContents(), true);
156156

157-
return array_map(function (array $item) {
158-
return Collection::make($item);
159-
}, $result);
157+
return array_map(fn(array $item) => Collection::make($item), $result);
160158
}
161159

162160
public function createCollection(string $database, string $tenant, CreateCollectionRequest $request): Collection

src/Generated/Exceptions/ValidationException.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public function __construct(
1212
string $message,
1313
public readonly string $type,
1414
int $code = 422,
15-
\Throwable $previous = null)
15+
\Throwable|null $previous = null)
1616
{
1717
parent::__construct($message, $code, $previous);
1818
}
@@ -40,4 +40,4 @@ public function toArray(): array
4040
];
4141
}
4242

43-
}
43+
}

src/Resources/CollectionResource.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,9 +401,7 @@ function validate(
401401

402402
$uniqueIds = array_unique($ids);
403403
if (count($uniqueIds) !== count($ids)) {
404-
$duplicateIds = array_filter($ids, function ($id) use ($ids) {
405-
return count(array_keys($ids, $id)) > 1;
406-
});
404+
$duplicateIds = array_filter($ids, fn($id) => count(array_keys($ids, $id)) > 1);
407405
throw new \InvalidArgumentException('Expected IDs to be unique, found duplicates for: ' . implode(', ', $duplicateIds));
408406
}
409407

0 commit comments

Comments
 (0)